Skip to content
This repository was archived by the owner on Aug 25, 2019. It is now read-only.

Syntax Highlighting is incorrect inside style and script blocks #11

Open
brycefranzen opened this issue May 15, 2019 · 6 comments
Open

Comments

@brycefranzen
Copy link

VSCode v1.33.1 laravel-blade v1.1.2

Syntax highlighting is incorrect in Style and Script Blocks:
image
image

However, Atom.io handles these cases correctly:
image
image

@cjhowedev
Copy link
Owner

Sounds like this extension needs to be converted from Atom again. I can do that.

@brycefranzen
Copy link
Author

awesome! Do you have an eta on that? Just curious :)

@7twin
Copy link

7twin commented Aug 25, 2019

@cjoftheweb the atom alternatives fix a lot of other issues too, is there any resources on how somebody else could port them as it seems this isn't maintained anymore?

@cjhowedev
Copy link
Owner

Yes, it's very easy, just convert this CSON file to JSON.

@7twin
Copy link

7twin commented Aug 25, 2019

@cjoftheweb oh wow, didn't expect it to be that easy, though I haven't really worked with language plugins for vsCode before, would it just work if I fork laravel-blade and replace the old https://github.com/cjoftheweb/laravel-blade-vscode/blob/master/syntaxes/blade.tmLanguage.json with the new one after cson to json?

@cjhowedev
Copy link
Owner

Yes, I put a deprecation notice on this repository - I suggest trying the linked extension. If the language file there is out of date, I suggest making a PR with the converted Atom syntax.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants