Unbox writer (3-5% faster) (#33)

alamb · web-flow · commit 632f87d459c0 · 2025-03-18T20:36:50.000-04:00
Unbox writer
diff --git a/tpchgen-cli/src/main.rs b/tpchgen-cli/src/main.rs
@@ -102,12 +102,10 @@ fn main() -> io::Result<()> {
     Ok(())
 }
 
-fn new_table_writer(cli: &Cli, filename: &str) -> io::Result<Box<dyn Write>> {
+fn new_table_writer(cli: &Cli, filename: &str) -> io::Result<BufWriter<File>> {
     let path = cli.output_dir.join(filename);
     let file = File::create(path)?;
-    let writer = BufWriter::with_capacity(32 * 1024, file);
-
-    Ok(Box::new(writer))
+    Ok(BufWriter::with_capacity(32 * 1024, file))
 }
 
 fn generate_nation(cli: &Cli) -> io::Result<()> {

Original file line number	Diff line number	Diff line change
`@@ -102,12 +102,10 @@ fn main() -> io::Result<()> {`
`102`	`102`	`Ok(())`
`103`	`103`	`}`
`104`	`104`
`105`		`-fn new_table_writer(cli: &Cli, filename: &str) -> io::Result<Box<dyn Write>> {`
	`105`	`+fn new_table_writer(cli: &Cli, filename: &str) -> io::Result<BufWriter<File>> {`
`106`	`106`	`let path = cli.output_dir.join(filename);`
`107`	`107`	`let file = File::create(path)?;`
`108`		`- let writer = BufWriter::with_capacity(32 * 1024, file);`
`109`		`-`
`110`		`- Ok(Box::new(writer))`
	`108`	`+ Ok(BufWriter::with_capacity(32 * 1024, file))`
`111`	`109`	`}`
`112`	`110`
`113`	`111`	`fn generate_nation(cli: &Cli) -> io::Result<()> {`