feat: Introduce gzipped test fixtures and steps to reproduce. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to build a nice test suite we need some initial fixtures that can be easily reproduced. In this change I add two sets of data files that I generated from the Java implementation for small scale factors (0.01 + 0.001) the idea is to have a small set of test data that we can easily build our test suite against. In the change are two patch files that explain how to reproduce the data itself (this is important since we should aim to have a reproducible flow).
|
Thanks @clflushopt
I will try and do the same thing with the original c implementation just to check that they match |
This was referenced Mar 12, 2025
|
Hi @clflushopt -- I compared the results that you checked in in this PR with the results from dbgen (the orignal C one) for both scale factors and I found one discrepancy I also made a PR with instructions that explain what I did: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to build a nice test suite we need some initial fixtures that can be easily reproduced. In this change I add two sets of data files that I generated from the Java implementation for small scale factors (0.01 + 0.001) the idea is to have a small set of test data that we can easily build our test suite against.
In the change are two patch files that explain how to reproduce the data itself (this is important since we should aim to have a reproducible flow).
This PR is the first step to address #4 (I will have a separate PR for #3), since we still want a tiered package of tests (unit for fast iteration and integration for ensuring compatibility).
@alamb FYI