Skip to content

enabling using multiple ssh keys for one user in sftp module #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

romga
Copy link

@romga romga commented Aug 4, 2024

what

*Enabling to add for one user multiple ssh keys

why

  • For some users, you want to let more than one ssh key - since you are connecting from more than one station

references

`closes #35

@romga romga requested review from a team as code owners August 4, 2024 08:01
@romga romga requested review from Gowiem and RoseSecurity August 4, 2024 08:01
@mergify mergify bot added the triage Needs triage label Aug 4, 2024
@romga
Copy link
Author

romga commented Aug 20, 2024

HI @Gowiem !
Can you please review? :)

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romga I believe I understand what you're getting at here and I like the direction, but since we're doing this enhancement, I want to do it right. Can you do the following for me:

  1. Update the type of sftp_users to be a list of object with strict typing to support the multiple key use-case that you're enabling here. Please update the name of the key to public_keys so it's clear that it's an array type. We'll issue this as a major version rev.
  2. Can you please include code comments in your data manipulations to explain what you're doing and how those new locals are used?

Let me know if you have any questions -- Thank you!

@romga
Copy link
Author

romga commented Aug 22, 2024

hi @Gowiem !

I have made the changes you have asked for!

Can you please review them? :)

Thank you!

@romga romga requested a review from Gowiem August 22, 2024 14:56
@romga
Copy link
Author

romga commented Sep 22, 2024

Hi @Gowiem
Can you please review?

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes required. Thanks @romga

@romga
Copy link
Author

romga commented Oct 13, 2024

Hi @Gowiem

I have pushed a new commit, can you please review now? :)

Thank you!

@Gowiem
Copy link
Member

Gowiem commented Oct 30, 2024

/terratest

@romga romga force-pushed the feautre/enabling-using-multiple-ssh-keys branch from 7840524 to 461c561 Compare October 31, 2024 08:27
@romg67
Copy link

romg67 commented Oct 31, 2024

Hi @Gowiem
I have fixed the fail tests.
can you please review again and rerun the the tests?

Thank you!

@Gowiem
Copy link
Member

Gowiem commented Oct 31, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Nov 5, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Nov 7, 2024

/terratest

Copy link

mergify bot commented Feb 3, 2025

💥 This pull request now has conflicts. Could you fix it @romga? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Feb 3, 2025
@mergify mergify bot closed this Feb 3, 2025
Copy link

mergify bot commented Feb 3, 2025

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple SSH keys per user
3 participants