Immich v1.135.0 - POTENTIAL BREAKING CHANGE

[vhsdream]

Hot new Immich just dropped, but don't update yet!

Please see #5025 for essential information about the changes. Only when the PR is merged is it OK to run the update. But it's not without risk.

[vhsdream]

While 1.135.0 is all good - DO NOT UPDATE TO 1.135.1 - their attempt to handle the issue with vchord breaks our install. Looking into it!

[oerix]

Appreciate the warning. Just to note, I updated to 1.135.0 prior to this warning and noticed that it broke 'SYMLINKS', I had to run those commands again to get it working.

[vhsdream]

@oerix That's odd. Can you provide your IMMICH_MEDIA_LOCATION env var from /opt/immich/.env?

and do ls -l for /opt/immich/app and /opt/immich/app/machine-learning, and if you recall what it looked like before you had to redo the symlinks, that would be a big help 👍🏼

[oerix]

@vhsdream It's basically the same setup from our conversation here.

The media location stayed the same (/mnt/photos) in the .env file. Although the upload folders for both (immich/app/upload) and (machine-learning/upload) defaulted back to the original path (opt/immich/upload) instead of (/mnt/photos)` after the upgrade.

[vhsdream]

Also, just tested the update from 1.135.0 - 1.135.2 and from 1.135.0 - 1.135.2 and they went OK, aside from my typo in the update script causing the DB to be reindexed unnecessarily.

[MickLesk]

You think 1.135.2 is running? The version is currently still fixed. Shall we change it back to the latest?

[vhsdream]

@MickLesk OK I will unpin.

Side note, I think I've found a bug in the fetch_and_deploy_gh_release function, at least when it comes to updating Immich that way.

[MickLesk]

And what?

[vhsdream]

So I think that the arguments are parsed improperly - since the way immich is deployed it gets put into /opt/immich/source, if you don't explicitly specify 'mode' and 'version', it breaks the script.

As I understand it, 'mode', 'version' and 'target' have default values if not specified: 'tarball', 'latest', and '/opt/$app', respectively.

But using fetch_and_deploy_gh_release "immich" "immich-app/immich" "$SRC_DIR" will fail because the 'target' value is shifted into the 'mode' value:

root@immich-test:~# fetch_and_deploy_gh_release "immich" "immich-app/immich" "$SRC_DIR"
+ fetch_and_deploy_gh_release immich immich-app/immich /opt/immich/source
+ set -x
+ local app=immich
+ local repo=immich-app/immich
+ local mode=/opt/immich/source
+ local version=latest
+ local target=/opt/immich

Similar thing happens if you specify only mode (version uses target value):

root@immich-test:~# 
root@immich-test:~# fetch_and_deploy_gh_release "immich" "immich-app/immich" "tarball" "$SRC_DIR"
+ fetch_and_deploy_gh_release immich immich-app/immich tarball /opt/immich/source
+ set -x
+ local app=immich
+ local repo=immich-app/immich
+ local mode=tarball
+ local version=/opt/immich/source
+ local target=/opt/immich

Or version (mode uses version value, and version uses target value):

root@immich-test:~# fetch_and_deploy_gh_release "immich" "immich-app/immich" "v1.135.1" "$SRC_DIR"
+ fetch_and_deploy_gh_release immich immich-app/immich v1.135.1 /opt/immich/source
+ set -x
+ local app=immich
+ local repo=immich-app/immich
+ local mode=v1.135.1
+ local version=/opt/immich/source
+ local target=/opt/immich

I'm still specifying the arguments in order, but if I don't specify an empty value for mode or version (or an explicit), then the defaults don't get applied.

Edit to add an example with blank arguments (which works):

root@immich-test:~# fetch_and_deploy_gh_release "immich" "immich-app/immich" "" "" "$SRC_DIR"
+ fetch_and_deploy_gh_release immich immich-app/immich '' '' /opt/immich/source
+ set -x
+ local app=immich
+ local repo=immich-app/immich
+ local mode=tarball
+ local version=latest
+ local target=/opt/immich/source