Broken

[jthrilly]

This pull request includes several changes aimed at refactoring and improving type safety, as well as enhancing the Redux state management in the interviewer module. The key changes are grouped into type conversion, Redux state management improvements, and code cleanup.

Type Conversion:

• Converted EgoForm component from JavaScript to TypeScript and added appropriate type annotations for props and internal functions (lib/interviewer/containers/Interfaces/EgoForm.tsx).

Redux State Management Improvements:

• Updated the protocol slice to use createSelector for memoized selectors to improve performance (lib/interviewer/ducks/modules/protocol.ts).
• Refactored session slice to use createSelector for getSessionMeta and updated addNode and updateEgo actions to include model data (lib/interviewer/ducks/modules/session.ts). [1] [2]
• Added updateEgo action to handle ego updates more effectively (lib/interviewer/ducks/modules/session.ts).

Code Cleanup:

• Removed unused PropTypes from EgoForm after converting to TypeScript (lib/interviewer/containers/Interfaces/EgoForm.tsx).
• Cleaned up and removed redundant code and comments in session reducer (lib/interviewer/ducks/modules/session.ts).

These changes collectively improve the type safety, performance, and maintainability of the codebase.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fresco-sandbox	❌ Failed (Inspect)			Apr 9, 2025 10:07pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
barf	⬜️ Ignored (Inspect)			Apr 9, 2025 10:07pm

[Copilot]

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

lib/interviewer/ducks/modules/session.ts:486

• The updateEgo action is now handled as a plain action rather than as an async thunk; please confirm that this change is intentional and update related logic and tests accordingly.

builder.addCase(updateEgo, (state, action) => {

lib/interviewer/containers/Interfaces/EgoForm.tsx:167

• [nitpick] Using non-null assertions on introductionPanel may hide potential issues if the data is missing; consider validating introductionPanel or refining its type for better robustness.

<h1>{introductionPanel!.title}</h1>

lib/interviewer/containers/Interfaces/NameGeneratorRoster/NameGeneratorRoster.js:151

• [nitpick] Ensure that the new addNode action signature—now requiring separate modelData and attributeData fields—is correctly integrated across all calling code and covered by tests.

dispatch(addNode({