fix: do not modify recipe outputs list (#5711)

* fix: do not extract outputs text for non-outputs

* doc: added news item

* fix: do not modify original

* refactor: clean up copy to only apply to metdata input

* fix: remove comment

* doc: update news item

* [ci skip] doc: update news item

* Update metadata.py

* fix: use .copy

Co-authored-by: jaimergp <[email protected]>

---------

Co-authored-by: jaimergp <[email protected]>

Author: beckermr

conda_build/metadata.py

@@ -994,7 +994,7 @@ def get_output_dicts_from_metadata(
     metadata: MetaData,
     outputs: list[dict[str, Any]] | None = None,
 ) -> list[dict[str, Any]]:
-    outputs = outputs or metadata.get_section("outputs")
+    outputs = outputs or metadata.get_section("outputs").copy()
 
     if not outputs:
         outputs = [{"name": metadata.name()}]

news/5711-implicit-metadata-recipe-text.md

@@ -0,0 +1,21 @@
+### Enhancements
+
+* <news item>
+
+### Bug fixes
+
+* Fixed bug where recipe outputs lists was modified during parsing. This
+  caused false-positive warnings about inconsistent recipe outputs due to
+  jinja2 structures and crashes when getting the recipe text. (#5711)
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>