Skip to content

fix: do not modify recipe outputs list #5711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented May 11, 2025

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

closes #5699
closes #5688

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 11, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review May 11, 2025
Copy link

codspeed-hq bot commented May 11, 2025

CodSpeed Performance Report

Merging #5711 will not alter performance

Comparing implicit-output-text (c251179) with main (d42396f)

Summary

✅ 5 untouched benchmarks

@beckermr beckermr changed the title fix: do not extract outputs text for non-outputs fix: do not modify recipe outputs list May 11, 2025
@beckermr beckermr marked this pull request as ready for review May 11, 2025 16:14
@beckermr beckermr requested a review from a team as a code owner May 11, 2025 16:14
@beckermr
Copy link
Contributor Author

@conda/builds-tools @jaimergp this one is ready for review!

@beckermr
Copy link
Contributor Author

BTW, the latest commit has [ci skip] since I changed the news item. The tests passed in the previous commit: https://github.com/conda/conda-build/actions/runs/14956677345

@beckermr
Copy link
Contributor Author

Bump here @conda/builds-tools. I may port this patch to the conda-forge feedstock since this bug appears pretty critical in terms of failures for certain recipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
2 participants