Fix multiple windows and tabs support #1739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VT: Backend
Yaraslaut
force-pushed
the
fix/tabs_and_multiple_windows
branch
2 times, most recently
from
205b526 to
b1a89f7
Compare
Yaraslaut
changed the title
Yaraslaut
force-pushed
the
fix/tabs_and_multiple_windows
branch
from
b1a89f7 to
502cd09
Compare
| @@ -107,7 +107,7 @@ inline void set_fail_handler(fail_handler_t handler) | |||
| #define Require(cond) \ | |||
| do \ | |||
| { \ | |||
| if (!(cond)) \ | |||
| if (false && !(cond)) \ | |||
There was a problem hiding this comment.
Disabling the assertion check by using 'false &&' will prevent any failure from being caught. Consider restoring the original condition to enforce the intended preconditions.
Suggested change
| if (false && !(cond)) \ | |
| if (!(cond)) \ |
Copilot uses AI. Check for mistakes.
| { | ||
| managerLog()("Session is already active. (index {}, ID {})", getCurrentSessionIndex(), session->id()); | ||
| return session; | ||
| managerLog()("No active display fond. something went wrong."); |
There was a problem hiding this comment.
There is a typo in the error message: 'fond' should be 'found'.
Suggested change
| managerLog()("No active display fond. something went wrong."); | |
| managerLog()("No active display found. something went wrong."); |
Copilot uses AI. Check for mistakes.
Yaraslaut
force-pushed
the
fix/tabs_and_multiple_windows
branch
from
502cd09 to
6c4e0c3
Compare
Yaraslaut
force-pushed
the
fix/tabs_and_multiple_windows
branch
from
6c4e0c3 to
5723019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1725
closes #1728
closes #1729
closes #1730