Fix(scan_for_text_asii): Fixed error and expanded tests with wider strings.

Author: Dooez

src/libunicode/scan.cpp

@@ -55,7 +55,7 @@ namespace
 
 size_t detail::scan_for_text_ascii(string_view text, size_t maxColumnCount) noexcept
 {
-#if defined(__x86_64__) || defined(_M_AMD64)
+#if (defined(LIBUNICODE_USE_STD_SIMD) || defined(LIBUNICODE_USE_INTRINSICS)) && defined(__x86_64__) || defined(_M_AMD64)
     static auto simd_size = max_simd_size();
     if (simd_size == 512)
     {

src/libunicode/scan_simd_impl.h

@@ -93,7 +93,7 @@ size_t scan_for_text_ascii_simd(std::string_view text, size_t maxColumnCount) no
 #endif
 
     constexpr auto is_ascii = [](char ch) noexcept {
-        auto is_control = static_cast<uint8_t>(ch) > 0x20;
+        auto is_control = static_cast<uint8_t>(ch) < 0x20;
         auto is_complex = static_cast<uint8_t>(ch) & 0x80;
         return !is_control && !is_complex;
     };

src/libunicode/scan_test.cpp

@@ -109,7 +109,12 @@ TEST_CASE("scan.ascii.empty")
 
 TEST_CASE("scan.ascii.32")
 {
-    auto const text = "0123456789ABCDEF0123456789ABCDEF"sv;
+    auto const text = "0123456789ABCDEF0123456789ABCDEF"
+                      "0123456789ABCDEF0123456789ABCDEF"
+                      "0123456789ABCDEF0123456789ABCDEF"
+                      "0123456789ABCDEF0123456789ABCDEF"sv;
+    CHECK(scan_for_text_ascii(text, 128) == 128);
+    CHECK(scan_for_text_ascii(text, 64) == 64);
     CHECK(scan_for_text_ascii(text, 32) == 32);
     CHECK(scan_for_text_ascii(text, 16) == 16);
     CHECK(scan_for_text_ascii(text, 8) == 8);
@@ -123,12 +128,22 @@ TEST_CASE("scan.ascii.mixed_with_controls")
     CHECK(scan_for_text_ascii("12345678\033", 80) == 8);
     CHECK(scan_for_text_ascii("0123456789ABCDEF\033", 80) == 16);
     CHECK(scan_for_text_ascii("0123456789ABCDEF1\033", 80) == 17);
+    constexpr auto text = "0123456789ABCDEF0\033123456789ABCDEF"
+                          "0123456789ABCDEF0123456789ABCDEF"
+                          "0123456789ABCDEF0123456789ABCDEF"
+                          "0123456789ABCDEF0123456789ABCDEF"sv;
+    CHECK(scan_for_text_ascii(text, 80) == 17);
 }
 
 TEST_CASE("scan.ascii.until_complex")
 {
     CHECK(scan_for_text_ascii("1234\x80", 80) == 4);
     CHECK(scan_for_text_ascii("0123456789{\xE2\x94\x80}ABCDEF", 80) == 11);
+    constexpr auto text = "0123456789{\xE2\x94\x80}ABCDEF0323456789ABCDEF"
+                          "0123456789ABCDEF0123456789ABCDEF"
+                          "0123456789ABCDEF0123456789ABCDEF"
+                          "0123456789ABCDEF0123456789ABCDEF"sv;
+    CHECK(scan_for_text_ascii(text, 80) == 11);
 }
 
 TEST_CASE("scan.complex.grapheme_cluster.1")