Fix release workflow

Author: Fajfa

.eslintrc.js

@@ -1,18 +1,19 @@
 module.exports = {
-  root: false,
+  root: true,
   env: {
     node: true,
     es6: true,
     mocha: true,
   },
   extends: [
-    'standard',
+    'eslint:recommended',
     'plugin:@typescript-eslint/recommended',
   ],
     rules: {
     'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off',
     'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off',
     'comma-dangle': [ 'error', 'always-multiline' ],
+    '@typescript-eslint/no-require-imports': 'off',
   },
   parser: '@typescript-eslint/parser',
   plugins: [

package.json

@@ -42,7 +42,7 @@
     "@typescript-eslint/parser": "^8.22.0",
     "chai": "^5.1.2",
     "chai-as-promised": "^8.0.1",
-    "eslint": "^9.19.0",
+    "eslint": "^8.7.2",
     "eslint-import-resolver-typescript": "^3.7.0",
     "eslint-plugin-import": "^2.31.0",
     "eslint-plugin-json": "^4.0.1",

src/bundler/server-scripts.ts

@@ -43,7 +43,7 @@ function BootLoader (outputPath: string, ss: Array<Script>): string {
  *
  * @constructor
  */
-function Pack (entry, context, outputPath): Promise<string> {
+function Pack (entry: string, context: string, outputPath: string): Promise<string> {
   return new Promise((resolve) => {
     const type = 'server-scripts'
     const cfg: webpack.Configuration = {
@@ -59,14 +59,14 @@ function Pack (entry, context, outputPath): Promise<string> {
       },
     }
 
-    webpack(cfg).run((err: Error) => {
+    webpack(cfg).run((err: Error | null) => {
       if (err) return console.error(err)
       resolve(`${outputPath}/${type}.js`)
     })
   })
 }
 
-function Load (path): Map<string, Partial<Script>> {
+function Load (path: string): Map<string, Partial<Script>> {
   delete require.cache[require.resolve(path)]
   return require(path).default
 }

src/grpc-server/errors.ts

@@ -45,7 +45,7 @@ export function HandleException (log: Logger, err: APIError, done: grpc.sendUnar
     name,
     message,
     details: '',
-    metadata: new grpc.Metadata()
+    metadata: new grpc.Metadata(),
   }
 
   if (code !== grpc.status.ABORTED) {

src/grpc-server/server.ts

@@ -54,9 +54,7 @@ export function Start ({ addr, certificates }: ServerConfig, logger: Logger, ser
       fs.readFileSync(certificates.ca),
       [
         {
-          // eslint-disable-next-line @typescript-eslint/camelcase
           cert_chain: fs.readFileSync(certificates.public),
-          // eslint-disable-next-line @typescript-eslint/camelcase
           private_key: fs.readFileSync(certificates.private),
         },
       ],

src/scripts/parser.test.ts

@@ -1,9 +1,6 @@
-/* eslint-disable no-unused-expressions,@typescript-eslint/no-empty-function,@typescript-eslint/ban-ts-ignore */
-
 import { describe, it } from 'mocha'
 import * as chai from 'chai'
 import SourceParser from './parser'
-// @ts-ignore
 import chaiAsPromised from 'chai-as-promised'
 import { Script } from '../types'
 import { Trigger } from './trigger'

src/scripts/trigger.test.ts

@@ -1,5 +1,3 @@
-/* eslint-disable no-unused-expressions,@typescript-eslint/no-empty-function,@typescript-eslint/ban-ts-ignore */
-
 import { describe, it } from 'mocha'
 import { expect } from 'chai'
 import Make, { Trigger } from './trigger'

src/server.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/ban-ts-ignore */
-
 import path from 'path'
 import logger from './logger'
 import * as config from './config'
@@ -80,7 +78,7 @@ gRPCServer
   .then(corredor => {
     const serviceDefinitions: gRPCServer.ServiceDefinition = new Map()
     serviceDefinitions.set(
-      // @ts-ignore
+      // @ts-expect-error service is defined
       corredor.ServerScripts.service,
       ServerScriptsHandler(
         serverScriptsService,
@@ -89,7 +87,7 @@ gRPCServer
     )
 
     serviceDefinitions.set(
-      // @ts-ignore
+      // @ts-expect-error service is defined
       corredor.ClientScripts.service,
       ClientScriptsHandler(
         clientScriptsService,
@@ -106,7 +104,9 @@ gRPCServer
 
 try {
   Promise.all([
+    // @ts-expect-error service is defined
     serverScriptsService.process(),
+    // @ts-expect-error service is defined
     clientScriptsService.process(),
   ])
 

src/services/server-scripts.test.ts

@@ -1,10 +1,7 @@
 import { describe, it } from 'mocha'
 import { expect } from 'chai'
 
-// eslint-disable-next-line @typescript-eslint/ban-ts-ignore
-// @ts-ignore
 import pino from 'pino'
-// ^ for some peculiar reason, IDE is not happy with this import
 import ServerScripts from './server-scripts'
 import { Trigger } from '../scripts/trigger'