App to not run messages on CheckTx

[rigelrozanski]

May be a duplicate issue?

As discussed many times previously we need checkTx to only check that fees can be paid, from there on the messages should not run validate basic to waste unpaid time - the transactions should then pass checktx and be allowed to fail on delivertx.

[rigelrozanski]

As a part of this validate basic should be removed from the message struct - those validations no longer need to be separated out and should just be brought into msg handler

[davekay100]

@rigelrozanski I've started to work on implementing this fix in this WIP PR https://github.com/cosmos/cosmos-sdk/pull/1172/files . I got a few questions outlined in the PR if you get a chance to answer them.

[davekay100]

this issue is related #518

[rigelrozanski]

Thanks as per newest discussion within #518 we should implement this within the baseapp level such that handlers have no need to call IsCheckTx - in the future we will implement new handlers which can be referenced during checkTx however there is no need before launch

[rigelrozanski]

@davekaj I've commented in detail on your PR questions - also see my PR comments - thanks for putting in the time here!

[rigelrozanski]

let's keep validate basic! nice to have a check on the message without requiring access to state - good convention

[ebuchman]

Being addressed in #1172

[alexanderbez]

@ebuchman can we close this?

[ebuchman]

No it hasn't actually been addressed yet :)