remove .runsettings

Author: Bertk

Directory.Build.props

@@ -9,8 +9,8 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
-    <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <AnalysisLevel>preview</AnalysisLevel>
+    <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <LangVersion>preview</LangVersion>
     <NoWarn>$(NoWarn);NU5105;CS1591</NoWarn>

Directory.Packages.props

@@ -5,8 +5,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <GlobalPackageReference  Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
-    <GlobalPackageReference  Include="Nerdbank.GitVersioning" Version="3.6.133" />
+    <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
+    <GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.6.133" />
+    <!--<GlobalPackageReference Include="SonarAnalyzer.CSharp" Version="9.10.0.77988" />-->
   </ItemGroup>
 
   <ItemGroup>
@@ -58,6 +59,6 @@
     <PackageVersion Include="xunit.assemblyfixture" Version="2.2.0" />
     <PackageVersion Include="xunit.assert" Version="2.5.0" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.5.0"/>
-
+    <PackageVersion Include="envdte" Version="17.7.37355" />
   </ItemGroup>
 </Project>

src/coverlet.core/Exceptions.cs

@@ -6,7 +6,7 @@
 namespace Coverlet.Core.Exceptions
 {
     [Serializable]
-    internal class CoverletException : Exception
+    public class CoverletException : Exception
     {
         public CoverletException() { }
         public CoverletException(string message) : base(message) { }

src/coverlet.msbuild.tasks/InstrumentationTask.cs

@@ -116,8 +116,9 @@ public override bool Execute()
                                                  ServiceProvider.GetService<ICecilSymbolHelper>());
 
                 CoveragePrepareResult prepareResult = coverage.PrepareModules();
-                InstrumenterState = new TaskItem(System.IO.Path.GetTempFileName());
-                using Stream instrumentedStateFile = fileSystem.NewFileStream(InstrumenterState.ItemSpec, FileMode.Open, FileAccess.Write);
+                string randomPath = System.IO.Path.Combine(System.IO.Path.GetTempPath(), System.IO.Path.GetRandomFileName());
+                InstrumenterState = new TaskItem(randomPath);
+                using Stream instrumentedStateFile = fileSystem.NewFileStream(InstrumenterState.ItemSpec, FileMode.CreateNew, FileAccess.Write);
                 using Stream serializedState = CoveragePrepareResult.Serialize(prepareResult);
                 serializedState.CopyTo(instrumentedStateFile);
             }

test/coverlet.core.tests/coverlet.core.tests.csproj

@@ -22,6 +22,8 @@
     <PackageReference Include="Tmds.ExecFunction" />
     <PackageReference Include="xunit" />
     <PackageReference Include="xunit.runner.visualstudio" />
+    <!-- https://github.com/tmds/Tmds.ExecFunction/blob/15b5456a49c2d2bd34b59dc8e7c88bc34ac674a0/src/Tmds.ExecFunction/Tmds.ExecFunction.targets#L3C1-L3C1 workaraound -->
+    <PackageReference Include="envdte" VersionOverride="17.7.37355" />
   </ItemGroup>
 
   <ItemGroup>

test/coverlet.integration.tests/DeterministicBuild.cs

@@ -6,7 +6,6 @@
     <Nullable>enable</Nullable>
     <IsTestProject>true</IsTestProject>
     <IsPackable>false</IsPackable>
-    <RunSettingsFilePath>$(MSBuildThisFileDirectory).runsettings</RunSettingsFilePath>
   </PropertyGroup>
 
   <ItemGroup>

test/coverlet.msbuild.tasks.tests/.runsettings

@@ -0,0 +1,8 @@
+# top-most EditorConfig file
+# We don't want to import other EditorConfig files and we want
+# to ensure no rules are enabled for these asset source files.
+root = true
+
+[*.cs]
+# Default severity for all analyzer diagnostics
+dotnet_analyzer_diagnostic.severity = none