Send notification on explicit recording stop (#796)

Author: Janelle Law

src/main/java/io/cryostat/net/web/http/api/v1/HttpApiV1Module.java

@@ -37,6 +37,7 @@
  */
 package io.cryostat.net.web.http.api.v1;
 
+import io.cryostat.messaging.notifications.NotificationFactory;
 import io.cryostat.net.TargetConnectionManager;
 import io.cryostat.net.web.http.RequestHandler;
 import io.cryostat.recordings.RecordingArchiveHelper;
@@ -98,8 +99,9 @@ static TargetRecordingPatchSave provideTargetRecordingPatchSave(
 
     @Provides
     static TargetRecordingPatchStop provideTargetRecordingPatchStop(
-            TargetConnectionManager targetConnectionManager) {
-        return new TargetRecordingPatchStop(targetConnectionManager);
+            TargetConnectionManager targetConnectionManager,
+            NotificationFactory notificationFactory) {
+        return new TargetRecordingPatchStop(targetConnectionManager, notificationFactory);
     }
 
     @Binds

src/main/java/io/cryostat/net/web/http/api/v1/TargetRecordingPatchStop.java

@@ -37,25 +37,34 @@
  */
 package io.cryostat.net.web.http.api.v1;
 
+import java.util.Map;
 import java.util.Optional;
 
 import javax.inject.Inject;
 
 import org.openjdk.jmc.rjmx.services.jfr.IRecordingDescriptor;
 
+import io.cryostat.messaging.notifications.NotificationFactory;
 import io.cryostat.net.ConnectionDescriptor;
 import io.cryostat.net.TargetConnectionManager;
+import io.cryostat.net.web.http.HttpMimeType;
 
 import io.vertx.ext.web.RoutingContext;
 import io.vertx.ext.web.handler.impl.HttpStatusException;
 
 class TargetRecordingPatchStop {
 
     private final TargetConnectionManager targetConnectionManager;
+    private final NotificationFactory notificationFactory;
+
+    private static final String NOTIFICATION_CATEGORY = "RecordingStopped";
 
     @Inject
-    TargetRecordingPatchStop(TargetConnectionManager targetConnectionManager) {
+    TargetRecordingPatchStop(
+            TargetConnectionManager targetConnectionManager,
+            NotificationFactory notificationFactory) {
         this.targetConnectionManager = targetConnectionManager;
+        this.notificationFactory = notificationFactory;
     }
 
     void handle(RoutingContext ctx, ConnectionDescriptor connectionDescriptor) throws Exception {
@@ -80,5 +89,18 @@ void handle(RoutingContext ctx, ConnectionDescriptor connectionDescriptor) throw
                 });
         ctx.response().setStatusCode(200);
         ctx.response().end();
+
+        notificationFactory
+                .createBuilder()
+                .metaCategory(NOTIFICATION_CATEGORY)
+                .metaType(HttpMimeType.JSON)
+                .message(
+                        Map.of(
+                                "recording",
+                                recordingName,
+                                "target",
+                                connectionDescriptor.getTargetId()))
+                .build()
+                .send();
     }
 }

src/test/java/io/cryostat/net/web/http/api/v1/TargetRecordingPatchStopTest.java

@@ -43,8 +43,11 @@
 import org.openjdk.jmc.rjmx.services.jfr.IRecordingDescriptor;
 
 import io.cryostat.core.net.JFRConnection;
+import io.cryostat.messaging.notifications.Notification;
+import io.cryostat.messaging.notifications.NotificationFactory;
 import io.cryostat.net.ConnectionDescriptor;
 import io.cryostat.net.TargetConnectionManager;
+import io.cryostat.net.web.http.HttpMimeType;
 
 import io.vertx.core.http.HttpServerResponse;
 import io.vertx.ext.web.RoutingContext;
@@ -71,10 +74,28 @@ class TargetRecordingPatchStopTest {
     @Mock HttpServerResponse resp;
     @Mock JFRConnection connection;
     @Mock IFlightRecorderService service;
+    @Mock NotificationFactory notificationFactory;
+    @Mock Notification notification;
+    @Mock Notification.Builder notificationBuilder;
 
     @BeforeEach
     void setup() {
-        this.patchStop = new TargetRecordingPatchStop(targetConnectionManager);
+        Mockito.lenient().when(notificationFactory.createBuilder()).thenReturn(notificationBuilder);
+        Mockito.lenient()
+                .when(notificationBuilder.metaCategory(Mockito.any()))
+                .thenReturn(notificationBuilder);
+        Mockito.lenient()
+                .when(notificationBuilder.metaType(Mockito.any(Notification.MetaType.class)))
+                .thenReturn(notificationBuilder);
+        Mockito.lenient()
+                .when(notificationBuilder.metaType(Mockito.any(HttpMimeType.class)))
+                .thenReturn(notificationBuilder);
+        Mockito.lenient()
+                .when(notificationBuilder.message(Mockito.any()))
+                .thenReturn(notificationBuilder);
+        Mockito.lenient().when(notificationBuilder.build()).thenReturn(notification);
+
+        this.patchStop = new TargetRecordingPatchStop(targetConnectionManager, notificationFactory);
     }
 
     @Test