Skip to content

Commit bc55e70

Browse files
committed
Added temporary debugging log
1 parent c74de0e commit bc55e70

File tree

3 files changed

+18
-14
lines changed

3 files changed

+18
-14
lines changed

examples/ocmd/ocmd-server-1.toml

+4-4
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,7 @@ driver = "memory"
6969
driver = "demo"
7070
iopsecret = "testsecret"
7171
wopiurl = "http://0.0.0.0:8880/"
72-
wopibridgeurl = "http://localhost:8000/"
73-
74-
[grpc.services.appprovider.mimetypes]
75-
".zmd" = "application/compressed-markdown"
72+
wopibridgeurl = "http://localhost:8000/wopib"
7673

7774
[grpc.services.appregistry]
7875
driver = "static"
@@ -93,6 +90,9 @@ expose_data_server = true
9390
data_server_url = "http://localhost:19001/data"
9491
enable_home_creation = true
9592

93+
[grpc.services.storageprovider.mimetypes]
94+
".zmd" = "application/compressed-markdown"
95+
9696
[grpc.services.storageprovider.drivers.localhome]
9797
user_layout = "{{.Username}}"
9898

internal/grpc/services/appprovider/appprovider.go

-10
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ import (
3535
"github.com/cs3org/reva/pkg/app"
3636
"github.com/cs3org/reva/pkg/app/provider/demo"
3737
"github.com/cs3org/reva/pkg/appctx"
38-
"github.com/cs3org/reva/pkg/mime"
3938
"github.com/cs3org/reva/pkg/rgrpc"
4039
"github.com/cs3org/reva/pkg/rgrpc/status"
4140
"github.com/cs3org/reva/pkg/rhttp"
@@ -59,7 +58,6 @@ type config struct {
5958
IopSecret string `mapstructure:"iopsecret" docs:";The iopsecret used to connect to the wopiserver."`
6059
WopiURL string `mapstructure:"wopiurl" docs:";The wopiserver's URL."`
6160
WopiBrURL string `mapstructure:"wopibridgeurl" docs:";The wopibridge's URL."`
62-
MimeTypes map[string]string `mapstructure:"mimetypes" docs:"nil;List of supported mime types and corresponding file extensions."`
6361
}
6462

6563
// New creates a new AppProviderService
@@ -69,8 +67,6 @@ func New(m map[string]interface{}, ss *grpc.Server) (rgrpc.Service, error) {
6967
return nil, err
7068
}
7169

72-
registerMimeTypes(c.MimeTypes)
73-
7470
provider, err := getProvider(c)
7571
if err != nil {
7672
return nil, err
@@ -92,12 +88,6 @@ func parseConfig(m map[string]interface{}) (*config, error) {
9288
return c, nil
9389
}
9490

95-
func registerMimeTypes(mimes map[string]string) {
96-
for k, v := range mimes {
97-
mime.RegisterMime(k, v)
98-
}
99-
}
100-
10191
func (s *service) Close() error {
10292
return nil
10393
}

internal/grpc/services/storageprovider/storageprovider.go

+14
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ import (
3333
provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
3434
"github.com/cs3org/reva/pkg/appctx"
3535
"github.com/cs3org/reva/pkg/errtypes"
36+
"github.com/cs3org/reva/pkg/logger"
37+
"github.com/cs3org/reva/pkg/mime"
3638
"github.com/cs3org/reva/pkg/rgrpc"
3739
"github.com/cs3org/reva/pkg/rgrpc/status"
3840
"github.com/cs3org/reva/pkg/storage"
@@ -57,6 +59,7 @@ type config struct {
5759
ExposeDataServer bool `mapstructure:"expose_data_server" docs:"false;Whether to expose data server."` // if true the client will be able to upload/download directly to it
5860
DisableTus bool `mapstructure:"disable_tus" docs:"false;Whether to disable TUS uploads."`
5961
AvailableXS map[string]uint32 `mapstructure:"available_checksums" docs:"nil;List of available checksums."`
62+
MimeTypes map[string]string `mapstructure:"mimetypes" docs:"nil;List of supported mime types and corresponding file extensions."`
6063
}
6164

6265
func (c *config) init() {
@@ -173,6 +176,8 @@ func New(m map[string]interface{}, ss *grpc.Server) (rgrpc.Service, error) {
173176
return nil, fmt.Errorf("no available checksum, please set in config")
174177
}
175178

179+
registerMimeTypes(c.MimeTypes)
180+
176181
service := &service{
177182
conf: c,
178183
storage: fs,
@@ -186,6 +191,15 @@ func New(m map[string]interface{}, ss *grpc.Server) (rgrpc.Service, error) {
186191
return service, nil
187192
}
188193

194+
func registerMimeTypes(mimes map[string]string) {
195+
tlog := logger.New().With().Int("pid", os.Getpid()).Logger()
196+
197+
for k, v := range mimes {
198+
tlog.Debug().Str("Registering mime type: ", "'"+fmt.Sprintf("%s -> %s", k, v)+"' ").Msg("")
199+
mime.RegisterMime(k, v)
200+
}
201+
}
202+
189203
func (s *service) SetArbitraryMetadata(ctx context.Context, req *provider.SetArbitraryMetadataRequest) (*provider.SetArbitraryMetadataResponse, error) {
190204
newRef, err := s.unwrap(ctx, req.Ref)
191205
if err != nil {

0 commit comments

Comments
 (0)