fix vet fmt mismatch errors

The latest Go version picks up these format string mismatches, so
fix them.

Signed-off-by: Roger Peppe <[email protected]>
Change-Id: I80a3779e569122950e30e572942b05ad69acf868
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1200762
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>

Author: rogpeppe

Diff for: cue/load/tags.go

@@ -241,7 +241,7 @@ func findTags(b *build.Instance) (tags []*tag, errs errors.Error) {
 			if f, ok := n.(*ast.Field); ok {
 				for _, a := range f.Attrs {
 					if key, _ := a.Split(); key == "tag" {
-						errs = errors.Append(errs, errors.Newf(a.Pos(), msg))
+						errs = errors.Append(errs, errors.Newf(a.Pos(), "%s", msg))
 						// TODO: add position of x.
 					}
 				}

Diff for: internal/core/compile/compile.go

@@ -1066,7 +1066,7 @@ func (c *compiler) parse(l *ast.BasicLit) (n adt.Expr) {
 	case token.STRING:
 		info, nStart, _, err := literal.ParseQuotes(s, s)
 		if err != nil {
-			return c.errf(l, err.Error())
+			return c.errf(l, "%s", err.Error())
 		}
 		s := s[nStart:]
 		return parseString(c, l, info, s)

Diff for: internal/golangorgx/gopls/cache/view.go

@@ -747,7 +747,7 @@ func (s *Snapshot) initialize(ctx context.Context, firstAttempt bool) {
 		}
 	case len(modDiagnostics) > 0:
 		initialErr = &InitializationError{
-			MainError: fmt.Errorf(modDiagnostics[0].Message),
+			MainError: fmt.Errorf("%s", modDiagnostics[0].Message),
 		}
 	}
 

Diff for: internal/golangorgx/gopls/test/integration/fake/editor.go

@@ -637,7 +637,7 @@ func (e *Editor) SaveBufferWithoutActions(ctx context.Context, path string) erro
 	defer e.mu.Unlock()
 	buf, ok := e.buffers[path]
 	if !ok {
-		return fmt.Errorf(fmt.Sprintf("unknown buffer: %q", path))
+		return fmt.Errorf("unknown buffer: %q", path)
 	}
 	content := buf.text()
 	includeText := false