internal/core/adt: move block of code

This should be a noop, but it allows hoisting
a continuous block of code related to closedness
processing into a separate function.

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Ie2dd5324b2ffbda91edbf8dd77ffb480e9607cf7
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207446
Reviewed-by: Daniel Martí <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

Author: mpvl

internal/core/adt/fields.go

@@ -671,22 +671,6 @@ func (c *closeContext) decDependent(ctx *OpContext, kind depKind, dependant *clo
 
 	c.done = true
 
-	p := c.parent
-
-	if c.isDef && !c.isTotal && (!c.hasTop || c.hasNonTop) {
-		c.isClosed = true
-		if p != nil {
-			p.isDef = true
-		}
-	}
-
-	if c.isClosedOnce {
-		c.isClosed = true
-		if p != nil {
-			p.isClosedOnce = true
-		}
-	}
-
 	for i, a := range c.arcs {
 		cc := a.cc
 		if a.decremented {
@@ -705,6 +689,22 @@ func (c *closeContext) decDependent(ctx *OpContext, kind depKind, dependant *clo
 		cc.decDependent(ctx, NOTIFY, c)
 	}
 
+	p := c.parent
+
+	if c.isDef && !c.isTotal && (!c.hasTop || c.hasNonTop) {
+		c.isClosed = true
+		if p != nil {
+			p.isDef = true
+		}
+	}
+
+	if c.isClosedOnce {
+		c.isClosed = true
+		if p != nil {
+			p.isClosedOnce = true
+		}
+	}
+
 	c.finalizePattern()
 
 	if p == nil {