cmd/cue: add a test case to reproduce #3644

Expand the existing non-local `cue get go` testscript
so that we need to keep looking for CUE files even when we find
a non-CUE file first. I introduced that bug recently, but unfortunately
the test happened to sidestep the issue.

Also rename externalmod.test/blah to externalmod.test/mixfiles
to clarify that its purpose is to mix CUE and non-CUE files,
and describe its purpose in its module.cue file.

For #3644.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I0c1bc012804e9d130d69f4256c028556b5e3726b
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207329
Reviewed-by: Roger Peppe <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207624
Reviewed-by: Paul Jolly <[email protected]>

Author: mvdan

cmd/cue/cmd/testdata/mod/externalmod.test_blah_v1.0.0.txtar

@@ -0,0 +1,32 @@
+-- .mod --
+module externalmod.test/mixfiles
+
+-- .info --
+{"Version":"v1.0.0","Time":"2018-10-22T18:45:39Z"}
+
+-- go.mod --
+// A module which mixes CUE, Go, and other files, to be tested with `cue get go`.
+
+module externalmod.test/mixfiles
+
+-- aa_first_noextension --
+Mix an uninteresting file at the beginning of the directory list
+to verify that we don't stop looking at the rest of the files.
+-- code_one.go --
+package mixfiles
+
+// Some fruit
+const NameOne = "Orange"
+-- code_two.go --
+package mixfiles
+
+const NameTwo = "Apple"
+-- config_one.cue --
+package mixfiles
+
+Type: "Fruit"
+-- config_two.cue --
+package mixfiles
+
+Type: string
+-- zz_last_noextension --

cmd/cue/cmd/testdata/mod/externalmod.test_mixfiles_v1.0.0.txtar

@@ -4,13 +4,18 @@
 # But this is going to change: "cue get go" will be renamed "cue import go".
 # When that change happens, cue import go will assume that all
 # required dependencies are present, and fail otherwise.
-go get externalmod.test/blah@v1.0.0
+go get externalmod.test/mixfiles@v1.0.0
 go mod tidy
 
 # cue get go
-exec cue get go externalmod.test/blah
-cmp cue.mod/gen/externalmod.test/blah/blah_go_gen.cue cue.mod/gen/externalmod.test/blah/blah_go_gen.cue.golden
-cmp cue.mod/gen/externalmod.test/blah/blah_gen.cue cue.mod/gen/externalmod.test/blah/blah_gen.cue.golden
+exec cue get go externalmod.test/mixfiles
+cmp cue.mod/gen/externalmod.test/mixfiles/code_one_go_gen.cue cue.mod/gen/externalmod.test/mixfiles/code_one_go_gen.cue.golden
+cmp cue.mod/gen/externalmod.test/mixfiles/code_two_go_gen.cue cue.mod/gen/externalmod.test/mixfiles/code_two_go_gen.cue.golden
+# TODO(mvdan): fix https://cuelang.org/issue/3644
+! exists cue.mod/gen/externalmod.test/mixfiles/config_one_gen.cue
+! exists cue.mod/gen/externalmod.test/mixfiles/config_two_gen.cue
+# cmp cue.mod/gen/externalmod.test/mixfiles/config_one_gen.cue cue.mod/gen/externalmod.test/mixfiles/config_one_gen.cue.golden
+# cmp cue.mod/gen/externalmod.test/mixfiles/config_two_gen.cue cue.mod/gen/externalmod.test/mixfiles/config_two_gen.cue.golden
 
 # Verify dependencies are as expected
 cmp go.mod go.mod.golden
@@ -40,28 +45,44 @@ module mod.test/local
 
 go 1.14
 
-require externalmod.test/blah v1.0.0
+require externalmod.test/mixfiles v1.0.0
 -- cuedeps.go --
 // +build cuedeps
 
 package cuedeps
 
 import (
-	_ "externalmod.test/blah"
+	_ "externalmod.test/mixfiles"
 )
--- cue.mod/gen/externalmod.test/blah/blah_go_gen.cue.golden --
+-- cue.mod/gen/externalmod.test/mixfiles/code_one_go_gen.cue.golden --
 // Code generated by cue get go. DO NOT EDIT.
 
-//cue:generate cue get go externalmod.test/blah
+//cue:generate cue get go externalmod.test/mixfiles
 
-package blah
+package mixfiles
 
-#Name: "Orange"
--- cue.mod/gen/externalmod.test/blah/blah_gen.cue.golden --
+#NameOne: "Orange"
+-- cue.mod/gen/externalmod.test/mixfiles/code_two_go_gen.cue.golden --
 // Code generated by cue get go. DO NOT EDIT.
 
-//cue:generate cue get go externalmod.test/blah
+//cue:generate cue get go externalmod.test/mixfiles
 
-package blah
+package mixfiles
+
+#NameTwo: "Apple"
+-- cue.mod/gen/externalmod.test/mixfiles/config_one_gen.cue.golden --
+// Code generated by cue get go. DO NOT EDIT.
+
+//cue:generate cue get go externalmod.test/mixfiles
+
+package mixfiles
 
 Type: "Fruit"
+-- cue.mod/gen/externalmod.test/mixfiles/config_two_gen.cue.golden --
+// Code generated by cue get go. DO NOT EDIT.
+
+//cue:generate cue get go externalmod.test/mixfiles
+
+package mixfiles
+
+Type: string

cmd/cue/cmd/testdata/script/get_go_non_local.txtar

@@ -1,7 +1,7 @@
 # Basic test to ensure that the goproxytest instance used by various testscript
 # tests works as expected.
 
-go get externalmod.test/blah
+go get externalmod.test/mixfiles
 go mod tidy
 cmp go.mod go.mod.golden
 
@@ -15,15 +15,15 @@ package main
 import (
 	"fmt"
 
-	"externalmod.test/blah"
+	"externalmod.test/mixfiles"
 )
 
 func main() {
-	fmt.Println(blah.Orange)
+	fmt.Println(mixfiles.Orange)
 }
 -- go.mod.golden --
 module test
 
 go 1.14
 
-require externalmod.test/blah v1.0.0
+require externalmod.test/mixfiles v1.0.0