cmd/cue: hide the --strict global flag

Showing it to the user with a deprecated note seems odd;
it's better to hide the flag entirely.
We keep the deprecated text around for now because we will likely
use it in the near future to make the flag give such a warning or error.

The upcoming release notes will also make a mention of this.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I5d0690fb588d8fda44601ec194e0ae5525924a95
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1201708
Reviewed-by: Roger Peppe <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>

Author: mvdan

cmd/cue/cmd/flags.go

@@ -78,12 +78,16 @@ func addGlobalFlags(f *pflag.FlagSet) {
 		"simplify output")
 	f.BoolP(string(flagIgnore), "i", false,
 		"proceed in the presence of errors")
-	f.Bool(string(flagStrict), false,
-		"report errors for lossy mappings (deprecated: use \"jsonschema+strict:\" filetype instead; see cue help filetypes)")
 	f.BoolP(string(flagVerbose), "v", false,
 		"print information about progress")
 	f.BoolP(string(flagAllErrors), "E", false, "print all available errors")
 
+	// Deprecated flags are hidden but still work for now.
+	// TODO(mvdan): make this flag give a warning or error in early 2025.
+	f.Bool(string(flagStrict), false,
+		"report errors for lossy mappings (deprecated: use \"jsonschema+strict:\" filetype instead; see cue help filetypes)")
+	f.MarkHidden(string(flagStrict))
+
 	f.String(string(flagCpuProfile), "", "write a CPU profile to the specified file before exiting")
 	f.MarkHidden(string(flagCpuProfile))
 	f.String(string(flagMemProfile), "", "write an allocation profile to the specified file before exiting")

cmd/cue/cmd/testdata/script/help_cmd.txtar

@@ -167,7 +167,6 @@ Global Flags:
   -E, --all-errors   print all available errors
   -i, --ignore       proceed in the presence of errors
   -s, --simplify     simplify output
-      --strict       report errors for lossy mappings (deprecated: use "jsonschema+strict:" filetype instead; see cue help filetypes)
       --trace        trace computation
   -v, --verbose      print information about progress
 
@@ -182,6 +181,5 @@ Global Flags:
   -E, --all-errors   print all available errors
   -i, --ignore       proceed in the presence of errors
   -s, --simplify     simplify output
-      --strict       report errors for lossy mappings (deprecated: use "jsonschema+strict:" filetype instead; see cue help filetypes)
       --trace        trace computation
   -v, --verbose      print information about progress

cmd/cue/cmd/testdata/script/help_cmd_flags.txtar

@@ -145,6 +145,5 @@ Global Flags:
   -E, --all-errors   print all available errors
   -i, --ignore       proceed in the presence of errors
   -s, --simplify     simplify output
-      --strict       report errors for lossy mappings (deprecated: use "jsonschema+strict:" filetype instead; see cue help filetypes)
       --trace        trace computation
   -v, --verbose      print information about progress