internal/core/adt: fix completion-related counter issue

We want to fix any incoming dependency as much
as possible before processing.
See comment in change.

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: I41291cdfa3103c37180fb00abe93bac5e8a2e856
Reviewed-on: https://cue.gerrithub.io/c/cue-lang/cue/+/1207750
Reviewed-by: Matthew Sackman <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

Author: mpvl

internal/core/adt/disjunct2.go

@@ -490,6 +490,14 @@ func (n *nodeContext) doDisjunct(c Conjunct, m defaultMode, mode runMode, hole i
 	// and then swapping it with disjunctCCs in the new nodeContext.
 	holes := make([]disjunctHole, 0, len(n.disjunctCCs))
 
+	// Complete as much of the pending work of this node and its parent before
+	// copying. Note that once a copy is made, the disjunct is no longer able
+	// to receive conjuncts from the original.
+	n.completeNodeTasks(mode)
+	// TODO: we may need to process incoming notifications for all arcs in
+	// the copied disjunct, but only those notifications not coming from
+	// within the arc itself.
+
 	// Clone the closeContexts of all open disjunctions and dependencies.
 	for _, d := range n.disjunctCCs {
 		// TODO: remove filled holes.

internal/core/adt/eval_test.go

@@ -77,7 +77,6 @@ var needFix = map[string]string{
 // TODO: These counters should all go to zero.
 var skipDebugDepErrors = map[string]int{
 	"disjunctions/elimination": 4,
-	"eval/issue545":            1,
 	"eval/notify":              3,
 }