Skip to content

Commit bd1839a

Browse files
committed
cue: re-enable tests on evalv3 which succeed now
These must have been fixed at some point in the past few months. While here, the tools/flow test was fixed in https://cuelang.org/cl/1194464 but the TODO comment was left behind. Signed-off-by: Daniel Martí <[email protected]> Change-Id: I0e7f61a449003d1fadae58a584a60c2a0b5f2738 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1212078 Unity-Result: CUE porcuepine <[email protected]> Reviewed-by: Matthew Sackman <[email protected]> TryBot-Result: CUEcueckoo <[email protected]>
1 parent 76d6e68 commit bd1839a

File tree

2 files changed

+2
-20
lines changed

2 files changed

+2
-20
lines changed

Diff for: cue/types_test.go

-14
Original file line numberDiff line numberDiff line change
@@ -1914,10 +1914,6 @@ func TestTemplate(t *testing.T) {
19141914
}}
19151915
for _, tc := range testCases {
19161916
cuetdtest.FullMatrix.Run(t, "", func(t *testing.T, m *cuetdtest.M) {
1917-
if tc.skip {
1918-
m.TODO_V3(t) // P2: reordering
1919-
}
1920-
19211917
v := getValue(m, tc.value)
19221918
for _, p := range tc.path {
19231919
if p == "" {
@@ -1978,10 +1974,6 @@ func TestElem(t *testing.T) {
19781974
}}
19791975
for _, tc := range testCases {
19801976
cuetdtest.FullMatrix.Run(t, "", func(t *testing.T, m *cuetdtest.M) {
1981-
if tc.skip {
1982-
m.TODO_V3(t) // P2: reordering
1983-
}
1984-
19851977
v := getValue(m, tc.value)
19861978
cue.ValueVertex(v).Finalize(cue.ValueCtx(v))
19871979
for _, p := range tc.path {
@@ -2658,10 +2650,6 @@ func TestValidate(t *testing.T) {
26582650
}}
26592651
for _, tc := range testCases {
26602652
cuetdtest.FullMatrix.Run(t, tc.desc, func(t *testing.T, m *cuetdtest.M) {
2661-
if tc.skip {
2662-
m.TODO_V3(t) // P1: wrong results
2663-
}
2664-
26652653
ctx := m.CueContext()
26662654
val := ctx.CompileString(tc.in, cue.Filename("validate"))
26672655
err := val.Validate(tc.opts...)
@@ -3210,8 +3198,6 @@ func TestWalk(t *testing.T) {
32103198
}}
32113199
for i, tc := range testCases {
32123200
cuetdtest.FullMatrix.Run(t, fmt.Sprintf("%d/%v", i, tc.value), func(t *testing.T, m *cuetdtest.M) {
3213-
m.TODO_V3(t) // P1: missing undefined field
3214-
32153201
val := getValue(m, tc.value)
32163202
buf := []byte{}
32173203
stripComma := func() {

Diff for: tools/flow/flow_test.go

+2-6
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,8 @@ import (
3838
// their dependencies.
3939
func TestFlow(t *testing.T) {
4040
test := cuetxtar.TxTarTest{
41-
Root: "./testdata",
42-
Name: "run",
43-
// TODO(evalv3): the breaking tests causes the synchronization to go out
44-
// of whack, causing the test to become flaky. We revert to the default
45-
// evaluator for now. Switch back to SmallMatrix when the tests are
46-
// fixed for the new evaluator.
41+
Root: "./testdata",
42+
Name: "run",
4743
Matrix: cuetdtest.SmallMatrix,
4844
}
4945

0 commit comments

Comments
 (0)