Skip to content

Commit c8b32e9

Browse files
committed
encoding/openapi: drop use of cue.Runtime from tests
That whole API is deprecated, and using cue.Value here is not hard. Signed-off-by: Daniel Martí <[email protected]> Change-Id: Ife32160db0f727b13536ecae87f9fc3d0b487681 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1201784 TryBot-Result: CUEcueckoo <[email protected]> Unity-Result: CUE porcuepine <[email protected]> Reviewed-by: Roger Peppe <[email protected]>
1 parent e339345 commit c8b32e9

File tree

1 file changed

+22
-12
lines changed

1 file changed

+22
-12
lines changed

encoding/openapi/decode_test.go

+22-12
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,14 @@ import (
2828
"golang.org/x/tools/txtar"
2929

3030
"cuelang.org/go/cue"
31+
"cuelang.org/go/cue/ast"
32+
"cuelang.org/go/cue/cuecontext"
3133
"cuelang.org/go/cue/errors"
3234
"cuelang.org/go/cue/format"
3335
"cuelang.org/go/encoding/json"
3436
"cuelang.org/go/encoding/openapi"
3537
"cuelang.org/go/encoding/yaml"
38+
"cuelang.org/go/internal"
3639
"cuelang.org/go/internal/cuetest"
3740
)
3841

@@ -57,17 +60,18 @@ func TestDecode(t *testing.T) {
5760

5861
cfg := &openapi.Config{PkgName: "foo"}
5962

60-
r := &cue.Runtime{}
61-
var in *cue.Instance
63+
var inFile *ast.File
6264
var out, errout []byte
6365
outIndex := -1
6466

6567
for i, f := range a.Files {
6668
switch path.Ext(f.Name) {
6769
case ".json":
68-
in, err = json.Decode(r, f.Name, f.Data)
70+
var inExpr ast.Expr
71+
inExpr, err = json.Extract(f.Name, f.Data)
72+
inFile = internal.ToFile(inExpr)
6973
case ".yaml":
70-
in, err = yaml.Decode(r, f.Name, f.Data)
74+
inFile, err = yaml.Extract(f.Name, f.Data)
7175
case ".cue":
7276
out = f.Data
7377
outIndex = i
@@ -78,8 +82,13 @@ func TestDecode(t *testing.T) {
7882
if err != nil {
7983
t.Fatal(err)
8084
}
85+
ctx := cuecontext.New()
86+
in := ctx.BuildFile(inFile)
87+
if err := in.Err(); err != nil {
88+
t.Fatal(err)
89+
}
8190

82-
expr, err := openapi.Extract(in, cfg)
91+
gotFile, err := openapi.Extract(in, cfg)
8392
if err != nil && errout == nil {
8493
t.Fatal(errors.Details(err, nil))
8594
}
@@ -91,17 +100,18 @@ func TestDecode(t *testing.T) {
91100
t.Error(diff)
92101
}
93102

94-
if expr != nil {
95-
b, err := format.Node(expr, format.Simplify())
96-
if err != nil {
97-
t.Fatal(err)
98-
}
99-
103+
if gotFile != nil {
100104
// verify the generated CUE.
101-
if _, err = r.Compile(fullpath, b); err != nil {
105+
v := ctx.BuildFile(gotFile, cue.Filename(fullpath))
106+
if err := v.Err(); err != nil {
102107
t.Fatal(errors.Details(err, nil))
103108
}
104109

110+
b, err := format.Node(gotFile, format.Simplify())
111+
if err != nil {
112+
t.Fatal(err)
113+
}
114+
105115
b = bytes.TrimSpace(b)
106116
out = bytes.TrimSpace(out)
107117

0 commit comments

Comments
 (0)