internal/core/adt: carry over more task types over disjunction boundaries

With the old closedness it was very hard to
carry over tasks as this would often lead to
counter issues. With new closedness this is
more straightforward.

This may fix 3770, but this CL only fixes a
reducer, so this should still be verified.

Issue #3770

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Ib3b0a7af2a15038f9b4fc3a3917b376c3c4fe763
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1211753
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>

Author: mpvl

cue/testdata/eval/counters.txtar

@@ -197,14 +197,14 @@ issue3770: task: {
   }
 }
 -- out/evalalpha/stats --
-Leaks:  225
+Leaks:  229
 Freed:  0
 Reused: 0
-Allocs: 225
+Allocs: 229
 Retain: 0
 
-Unifications: 172
-Conjuncts:    257
+Unifications: 176
+Conjuncts:    265
 Disjuncts:    34
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
@@ -216,17 +216,17 @@ diff old new
 -Reused: 138
 -Allocs: 13
 -Retain: 35
-+Leaks:  225
++Leaks:  229
 +Freed:  0
 +Reused: 0
-+Allocs: 225
++Allocs: 229
 +Retain: 0
 
 -Unifications: 125
 -Conjuncts:    229
 -Disjuncts:    186
-+Unifications: 172
-+Conjuncts:    257
++Unifications: 176
++Conjuncts:    265
 +Disjuncts:    34
 -- out/eval/stats --
 Leaks:  0
@@ -360,12 +360,10 @@ Disjuncts:    186
         }
         x: (struct){
           b: (int){ 1 }
+          a: (int){ 1 }
         }
       }
-      out: (_|_){
-        // [incomplete] issue3770.task.out: undefined field: a:
-        //     ./issue3770.cue:10:11
-      }
+      out: (int){ 1 }
     }
   }
   issue3780: (struct){
@@ -501,23 +499,6 @@ diff old new
          a: (struct){
            b: (_){ _ }
          }
-@@ -95,10 +119,12 @@
-         }
-         x: (struct){
-           b: (int){ 1 }
--          a: (int){ 1 }
--        }
--      }
--      out: (int){ 1 }
-+        }
-+      }
-+      out: (_|_){
-+        // [incomplete] issue3770.task.out: undefined field: a:
-+        //     ./issue3770.cue:10:11
-+      }
-     }
-   }
-   issue3780: (struct){
 -- out/eval --
 (struct){
   issue3750: (struct){

internal/core/adt/overlay.go

@@ -241,10 +241,8 @@ func (ctx *overlayContext) cloneScheduler(dst, src *nodeContext) {
 			ds.tasks = append(ds.tasks, t)
 
 		case taskRUNNING:
-			if t.run != handleResolver && t.run != handleExpr {
-				// TODO: consider whether this is also necessary for other
-				// types of tasks.
-				break
+			if t.run == handleDisjunctions {
+				continue
 			}
 
 			t.defunct = true