cue/errors: make wrapped.Path faster by bypassing unnecessary reflection

mxey · mvdan · commit e68bd632c29e · 2024-07-26T15:11:00.000Z
This makes one of our cue cmd runs noticeably faster, from ~52s to ~36s. Change-Id: I735875bfcd8b08f329a59a903d4c7c1ae195f269 Signed-off-by: Maximilian Gaß <mxey@mxey.net> Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1198494 TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
diff --git a/cue/errors/errors.go b/cue/errors/errors.go
@@ -223,7 +223,7 @@ func (e *wrapped) Msg() (format string, args []interface{}) {
 }
 
 func (e *wrapped) Path() []string {
-	if p := Path(e.main); p != nil {
+	if p := e.main.Path(); p != nil {
 		return p
 	}
 	return Path(e.wrap)

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ func (e *wrapped) Msg() (format string, args []interface{}) {`
`223`	`223`	`}`
`224`	`224`
`225`	`225`	`func (e *wrapped) Path() []string {`
`226`		`- if p := Path(e.main); p != nil {`
	`226`	`+ if p := e.main.Path(); p != nil {`
`227`	`227`	`return p`
`228`	`228`	`}`
`229`	`229`	`return Path(e.wrap)`