feedback on attr().

sainthkh · sainthkh · commit b1d2e9bebbb0 · 2021-11-17T09:18:03.000+09:00
diff --git a/packages/driver/cypress/integration/cy/snapshot_spec.js b/packages/driver/cypress/integration/cy/snapshot_spec.js
@@ -99,7 +99,7 @@ describe('driver/src/cy/snapshots', () => {
 
       cy.createSnapshot(null, this.$el)
 
-      expect(attr).to.be.calledWith('data-cypress-el', true)
+      expect(attr).to.be.calledWith('data-cypress-el', 'true')
     })
 
     it('removes data-cypress-el attr', function () {
diff --git a/packages/driver/src/cy/snapshots.ts b/packages/driver/src/cy/snapshots.ts
@@ -147,9 +147,7 @@ export default {
         const isJqueryElement = $dom.isElement($elToHighlight) && $dom.isJquery($elToHighlight)
 
         if (isJqueryElement) {
-          // JQuery.attr doesn't support `true` as a value.
-          // @ts-ignore
-          ($elToHighlight as JQuery<HTMLElement>).attr(HIGHLIGHT_ATTR, true)
+          ($elToHighlight as JQuery<HTMLElement>).attr(HIGHLIGHT_ATTR, 'true')
         }
 
         // TODO: throw error here if cy is undefined!

Original file line number	Diff line number	Diff line change
`@@ -147,9 +147,7 @@ export default {`
`147`	`147`	`const isJqueryElement = $dom.isElement($elToHighlight) && $dom.isJquery($elToHighlight)`
`148`	`148`
`149`	`149`	`if (isJqueryElement) {`
`150`		- // JQuery.attr doesn't support `true` as a value.
`151`		`- // @ts-ignore`
`152`		`- ($elToHighlight as JQuery<HTMLElement>).attr(HIGHLIGHT_ATTR, true)`
	`150`	`+ ($elToHighlight as JQuery<HTMLElement>).attr(HIGHLIGHT_ATTR, 'true')`
`153`	`151`	`}`
`154`	`152`
`155`	`153`	`// TODO: throw error here if cy is undefined!`