Skip to content

Remember folder permission when exporting APKs and configs #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WANGxHenry opened this issue Apr 2, 2025 · 3 comments
Open

Remember folder permission when exporting APKs and configs #1661

WANGxHenry opened this issue Apr 2, 2025 · 3 comments
Labels
c: AppControl enhancement New feature, request, improvement or optimization General UI/UX User Interface/Experience SAF Storage Access Framework

Comments

@WANGxHenry
Copy link

Just extract apks in the file,now need to allowed every time.

Screen_Recording_20250402_143603_SD.Maid.SE.mp4

It's not happened on sdmaid1,sdmaid 1 only one time authorized than extract app without ask,just extract apps in the file I set.

@WANGxHenry WANGxHenry added enhancement New feature, request, improvement or optimization triage This ticket needs to be sorted and labeled. labels Apr 2, 2025
@d4rken d4rken added c: AppControl and removed triage This ticket needs to be sorted and labeled. labels Apr 2, 2025
@d4rken
Copy link
Member

d4rken commented Apr 2, 2025

I think it is easier and more flexible the way it now is in SD Maid 2.
Just dumping all exported APK data into a specific folder, all the time, makes it difficult to find and organize the files. While SD Maid 1's behavior may be easier for your specific use case, I think most users find the current way easier.

Closing this as I will not change the implementation at this time.
If a significant amount of users think differently about this feature, feel free to discuss it and we can revisit changing it in the future.

@d4rken d4rken closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2025
@WANGxHenry
Copy link
Author

I think it is easier and more flexible the way it now is in SD Maid 2. Just dumping all exported APK data into a specific folder, all the time, makes it difficult to find and organize the files. While SD Maid 1's behavior may be easier for your specific use case, I think most users find the current way easier.

Closing this as I will not change the implementation at this time. If a significant amount of users think differently about this feature, feel free to discuss it and we can revisit changing it in the future.

Well,I'm means that permission in 8 sec .
I don't mind choose or creat new folder to extract apks,it's fine for me.
I means the difference between SDMaid 1 and 2,is the permission everytime.

After allowed all permission of SDmaid 1 in the beginning,the apk just extract into download folder,sdmaid1 didn't ask for the permission .

But sdmaid2 ask everytime even I allowed all permission in the begining setting.

So that's the issue I'm talking,haha.

Just confuse why I need to allowed system every time on SDMAID2?

@d4rken d4rken changed the title Just extract apks in the file,now need to allowed every time. Remember folder permission when exporting APKs and configs Apr 7, 2025
@d4rken d4rken added the General UI/UX User Interface/Experience label Apr 7, 2025
@d4rken
Copy link
Member

d4rken commented Apr 7, 2025

Reviewing this again after a discussion on discord.

While the system file picker will stay, SD Maid could theoretically remember the SAF permission given when selecting a previous folder for exports. So the "grant access dialog" no longer would have to show.

Caveats:

  • There is a soft limit on the number of SAF permissions an app can hold ~128?
  • We'd need logic to maintain this 128 permission count
  • Pay attention to definitely keep the SAF permission that are part of setup
  • Maybe a soft and basic SAF permission browser as part of the setup screen menu (like data areas)
  • Side question, does having large numbers of URI permissions slow down deletion or search because SAF path mapping gets more complicated?

@WANGxHenry If this was your original idea, sorry. Might have been a language barrier issue.

@d4rken d4rken reopened this Apr 7, 2025
@d4rken d4rken added the SAF Storage Access Framework label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: AppControl enhancement New feature, request, improvement or optimization General UI/UX User Interface/Experience SAF Storage Access Framework
Projects
None yet
Development

No branches or pull requests

2 participants