Skip to content

Commit 5c5670f

Browse files
yotamgidavem330
yotamgi
authored and
davem330
committed
net/sched: Introduce sample tc action
This action allows the user to sample traffic matched by tc classifier. The sampling consists of choosing packets randomly and sampling them using the psample module. The user can configure the psample group number, the sampling rate and the packet's truncation (to save kernel-user traffic). Example: To sample ingress traffic from interface eth1, one may use the commands: tc qdisc add dev eth1 handle ffff: ingress tc filter add dev eth1 parent ffff: \ matchall action sample rate 12 group 4 Where the first command adds an ingress qdisc and the second starts sampling randomly with an average of one sampled packet per 12 packets on dev eth1 to psample group 4. Signed-off-by: Yotam Gigi <[email protected]> Signed-off-by: Jiri Pirko <[email protected]> Acked-by: Jamal Hadi Salim <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 6ae0a62 commit 5c5670f

File tree

6 files changed

+364
-0
lines changed

6 files changed

+364
-0
lines changed

‎include/net/tc_act/tc_sample.h

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
#ifndef __NET_TC_SAMPLE_H
2+
#define __NET_TC_SAMPLE_H
3+
4+
#include <net/act_api.h>
5+
#include <linux/tc_act/tc_sample.h>
6+
#include <net/psample.h>
7+
8+
struct tcf_sample {
9+
struct tc_action common;
10+
u32 rate;
11+
bool truncate;
12+
u32 trunc_size;
13+
struct psample_group __rcu *psample_group;
14+
u32 psample_group_num;
15+
struct list_head tcfm_list;
16+
struct rcu_head rcu;
17+
};
18+
#define to_sample(a) ((struct tcf_sample *)a)
19+
20+
static inline bool is_tcf_sample(const struct tc_action *a)
21+
{
22+
#ifdef CONFIG_NET_CLS_ACT
23+
return a->ops && a->ops->type == TCA_ACT_SAMPLE;
24+
#else
25+
return false;
26+
#endif
27+
}
28+
29+
static inline __u32 tcf_sample_rate(const struct tc_action *a)
30+
{
31+
return to_sample(a)->rate;
32+
}
33+
34+
static inline bool tcf_sample_truncate(const struct tc_action *a)
35+
{
36+
return to_sample(a)->truncate;
37+
}
38+
39+
static inline int tcf_sample_trunc_size(const struct tc_action *a)
40+
{
41+
return to_sample(a)->trunc_size;
42+
}
43+
44+
static inline struct psample_group *
45+
tcf_sample_psample_group(const struct tc_action *a)
46+
{
47+
return rcu_dereference(to_sample(a)->psample_group);
48+
}
49+
50+
#endif /* __NET_TC_SAMPLE_H */

‎include/uapi/linux/tc_act/Kbuild

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ header-y += tc_defact.h
44
header-y += tc_gact.h
55
header-y += tc_ipt.h
66
header-y += tc_mirred.h
7+
header-y += tc_sample.h
78
header-y += tc_nat.h
89
header-y += tc_pedit.h
910
header-y += tc_skbedit.h

‎include/uapi/linux/tc_act/tc_sample.h

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
#ifndef __LINUX_TC_SAMPLE_H
2+
#define __LINUX_TC_SAMPLE_H
3+
4+
#include <linux/types.h>
5+
#include <linux/pkt_cls.h>
6+
#include <linux/if_ether.h>
7+
8+
#define TCA_ACT_SAMPLE 26
9+
10+
struct tc_sample {
11+
tc_gen;
12+
};
13+
14+
enum {
15+
TCA_SAMPLE_UNSPEC,
16+
TCA_SAMPLE_TM,
17+
TCA_SAMPLE_PARMS,
18+
TCA_SAMPLE_RATE,
19+
TCA_SAMPLE_TRUNC_SIZE,
20+
TCA_SAMPLE_PSAMPLE_GROUP,
21+
TCA_SAMPLE_PAD,
22+
__TCA_SAMPLE_MAX
23+
};
24+
#define TCA_SAMPLE_MAX (__TCA_SAMPLE_MAX - 1)
25+
26+
#endif

‎net/sched/Kconfig

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -650,6 +650,18 @@ config NET_ACT_MIRRED
650650
To compile this code as a module, choose M here: the
651651
module will be called act_mirred.
652652

653+
config NET_ACT_SAMPLE
654+
tristate "Traffic Sampling"
655+
depends on NET_CLS_ACT
656+
select PSAMPLE
657+
---help---
658+
Say Y here to allow packet sampling tc action. The packet sample
659+
action consists of statistically choosing packets and sampling
660+
them using the psample module.
661+
662+
To compile this code as a module, choose M here: the
663+
module will be called act_sample.
664+
653665
config NET_ACT_IPT
654666
tristate "IPtables targets"
655667
depends on NET_CLS_ACT && NETFILTER && IP_NF_IPTABLES

‎net/sched/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ obj-$(CONFIG_NET_CLS_ACT) += act_api.o
1010
obj-$(CONFIG_NET_ACT_POLICE) += act_police.o
1111
obj-$(CONFIG_NET_ACT_GACT) += act_gact.o
1212
obj-$(CONFIG_NET_ACT_MIRRED) += act_mirred.o
13+
obj-$(CONFIG_NET_ACT_SAMPLE) += act_sample.o
1314
obj-$(CONFIG_NET_ACT_IPT) += act_ipt.o
1415
obj-$(CONFIG_NET_ACT_NAT) += act_nat.o
1516
obj-$(CONFIG_NET_ACT_PEDIT) += act_pedit.o

‎net/sched/act_sample.c

Lines changed: 274 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,274 @@
1+
/*
2+
* net/sched/act_sample.c - Packet sampling tc action
3+
* Copyright (c) 2017 Yotam Gigi <[email protected]>
4+
*
5+
* This program is free software; you can redistribute it and/or modify
6+
* it under the terms of the GNU General Public License version 2 as
7+
* published by the Free Software Foundation.
8+
*/
9+
10+
#include <linux/types.h>
11+
#include <linux/kernel.h>
12+
#include <linux/string.h>
13+
#include <linux/errno.h>
14+
#include <linux/skbuff.h>
15+
#include <linux/rtnetlink.h>
16+
#include <linux/module.h>
17+
#include <linux/init.h>
18+
#include <linux/gfp.h>
19+
#include <net/net_namespace.h>
20+
#include <net/netlink.h>
21+
#include <net/pkt_sched.h>
22+
#include <linux/tc_act/tc_sample.h>
23+
#include <net/tc_act/tc_sample.h>
24+
#include <net/psample.h>
25+
26+
#include <linux/if_arp.h>
27+
28+
#define SAMPLE_TAB_MASK 7
29+
static unsigned int sample_net_id;
30+
static struct tc_action_ops act_sample_ops;
31+
32+
static const struct nla_policy sample_policy[TCA_SAMPLE_MAX + 1] = {
33+
[TCA_SAMPLE_PARMS] = { .len = sizeof(struct tc_sample) },
34+
[TCA_SAMPLE_RATE] = { .type = NLA_U32 },
35+
[TCA_SAMPLE_TRUNC_SIZE] = { .type = NLA_U32 },
36+
[TCA_SAMPLE_PSAMPLE_GROUP] = { .type = NLA_U32 },
37+
};
38+
39+
static int tcf_sample_init(struct net *net, struct nlattr *nla,
40+
struct nlattr *est, struct tc_action **a, int ovr,
41+
int bind)
42+
{
43+
struct tc_action_net *tn = net_generic(net, sample_net_id);
44+
struct nlattr *tb[TCA_SAMPLE_MAX + 1];
45+
struct psample_group *psample_group;
46+
struct tc_sample *parm;
47+
struct tcf_sample *s;
48+
bool exists = false;
49+
int ret;
50+
51+
if (!nla)
52+
return -EINVAL;
53+
ret = nla_parse_nested(tb, TCA_SAMPLE_MAX, nla, sample_policy);
54+
if (ret < 0)
55+
return ret;
56+
if (!tb[TCA_SAMPLE_PARMS] || !tb[TCA_SAMPLE_RATE] ||
57+
!tb[TCA_SAMPLE_PSAMPLE_GROUP])
58+
return -EINVAL;
59+
60+
parm = nla_data(tb[TCA_SAMPLE_PARMS]);
61+
62+
exists = tcf_hash_check(tn, parm->index, a, bind);
63+
if (exists && bind)
64+
return 0;
65+
66+
if (!exists) {
67+
ret = tcf_hash_create(tn, parm->index, est, a,
68+
&act_sample_ops, bind, false);
69+
if (ret)
70+
return ret;
71+
ret = ACT_P_CREATED;
72+
} else {
73+
tcf_hash_release(*a, bind);
74+
if (!ovr)
75+
return -EEXIST;
76+
}
77+
s = to_sample(*a);
78+
79+
ASSERT_RTNL();
80+
s->tcf_action = parm->action;
81+
s->rate = nla_get_u32(tb[TCA_SAMPLE_RATE]);
82+
s->psample_group_num = nla_get_u32(tb[TCA_SAMPLE_PSAMPLE_GROUP]);
83+
psample_group = psample_group_get(net, s->psample_group_num);
84+
if (!psample_group)
85+
return -ENOMEM;
86+
RCU_INIT_POINTER(s->psample_group, psample_group);
87+
88+
if (tb[TCA_SAMPLE_TRUNC_SIZE]) {
89+
s->truncate = true;
90+
s->trunc_size = nla_get_u32(tb[TCA_SAMPLE_TRUNC_SIZE]);
91+
}
92+
93+
if (ret == ACT_P_CREATED)
94+
tcf_hash_insert(tn, *a);
95+
return ret;
96+
}
97+
98+
static void tcf_sample_cleanup_rcu(struct rcu_head *rcu)
99+
{
100+
struct tcf_sample *s = container_of(rcu, struct tcf_sample, rcu);
101+
struct psample_group *psample_group;
102+
103+
psample_group = rcu_dereference_protected(s->psample_group, 1);
104+
RCU_INIT_POINTER(s->psample_group, NULL);
105+
psample_group_put(psample_group);
106+
}
107+
108+
static void tcf_sample_cleanup(struct tc_action *a, int bind)
109+
{
110+
struct tcf_sample *s = to_sample(a);
111+
112+
call_rcu(&s->rcu, tcf_sample_cleanup_rcu);
113+
}
114+
115+
static bool tcf_sample_dev_ok_push(struct net_device *dev)
116+
{
117+
switch (dev->type) {
118+
case ARPHRD_TUNNEL:
119+
case ARPHRD_TUNNEL6:
120+
case ARPHRD_SIT:
121+
case ARPHRD_IPGRE:
122+
case ARPHRD_VOID:
123+
case ARPHRD_NONE:
124+
return false;
125+
default:
126+
return true;
127+
}
128+
}
129+
130+
static int tcf_sample_act(struct sk_buff *skb, const struct tc_action *a,
131+
struct tcf_result *res)
132+
{
133+
struct tcf_sample *s = to_sample(a);
134+
struct psample_group *psample_group;
135+
int retval;
136+
int size;
137+
int iif;
138+
int oif;
139+
140+
tcf_lastuse_update(&s->tcf_tm);
141+
bstats_cpu_update(this_cpu_ptr(s->common.cpu_bstats), skb);
142+
retval = READ_ONCE(s->tcf_action);
143+
144+
rcu_read_lock();
145+
psample_group = rcu_dereference(s->psample_group);
146+
147+
/* randomly sample packets according to rate */
148+
if (psample_group && (prandom_u32() % s->rate == 0)) {
149+
if (!skb_at_tc_ingress(skb)) {
150+
iif = skb->skb_iif;
151+
oif = skb->dev->ifindex;
152+
} else {
153+
iif = skb->dev->ifindex;
154+
oif = 0;
155+
}
156+
157+
/* on ingress, the mac header gets popped, so push it back */
158+
if (skb_at_tc_ingress(skb) && tcf_sample_dev_ok_push(skb->dev))
159+
skb_push(skb, skb->mac_len);
160+
161+
size = s->truncate ? s->trunc_size : skb->len;
162+
psample_sample_packet(psample_group, skb, size, iif, oif,
163+
s->rate);
164+
165+
if (skb_at_tc_ingress(skb) && tcf_sample_dev_ok_push(skb->dev))
166+
skb_pull(skb, skb->mac_len);
167+
}
168+
169+
rcu_read_unlock();
170+
return retval;
171+
}
172+
173+
static int tcf_sample_dump(struct sk_buff *skb, struct tc_action *a,
174+
int bind, int ref)
175+
{
176+
unsigned char *b = skb_tail_pointer(skb);
177+
struct tcf_sample *s = to_sample(a);
178+
struct tc_sample opt = {
179+
.index = s->tcf_index,
180+
.action = s->tcf_action,
181+
.refcnt = s->tcf_refcnt - ref,
182+
.bindcnt = s->tcf_bindcnt - bind,
183+
};
184+
struct tcf_t t;
185+
186+
if (nla_put(skb, TCA_SAMPLE_PARMS, sizeof(opt), &opt))
187+
goto nla_put_failure;
188+
189+
tcf_tm_dump(&t, &s->tcf_tm);
190+
if (nla_put_64bit(skb, TCA_SAMPLE_TM, sizeof(t), &t, TCA_SAMPLE_PAD))
191+
goto nla_put_failure;
192+
193+
if (nla_put_u32(skb, TCA_SAMPLE_RATE, s->rate))
194+
goto nla_put_failure;
195+
196+
if (s->truncate)
197+
if (nla_put_u32(skb, TCA_SAMPLE_TRUNC_SIZE, s->trunc_size))
198+
goto nla_put_failure;
199+
200+
if (nla_put_u32(skb, TCA_SAMPLE_PSAMPLE_GROUP, s->psample_group_num))
201+
goto nla_put_failure;
202+
return skb->len;
203+
204+
nla_put_failure:
205+
nlmsg_trim(skb, b);
206+
return -1;
207+
}
208+
209+
static int tcf_sample_walker(struct net *net, struct sk_buff *skb,
210+
struct netlink_callback *cb, int type,
211+
const struct tc_action_ops *ops)
212+
{
213+
struct tc_action_net *tn = net_generic(net, sample_net_id);
214+
215+
return tcf_generic_walker(tn, skb, cb, type, ops);
216+
}
217+
218+
static int tcf_sample_search(struct net *net, struct tc_action **a, u32 index)
219+
{
220+
struct tc_action_net *tn = net_generic(net, sample_net_id);
221+
222+
return tcf_hash_search(tn, a, index);
223+
}
224+
225+
static struct tc_action_ops act_sample_ops = {
226+
.kind = "sample",
227+
.type = TCA_ACT_SAMPLE,
228+
.owner = THIS_MODULE,
229+
.act = tcf_sample_act,
230+
.dump = tcf_sample_dump,
231+
.init = tcf_sample_init,
232+
.cleanup = tcf_sample_cleanup,
233+
.walk = tcf_sample_walker,
234+
.lookup = tcf_sample_search,
235+
.size = sizeof(struct tcf_sample),
236+
};
237+
238+
static __net_init int sample_init_net(struct net *net)
239+
{
240+
struct tc_action_net *tn = net_generic(net, sample_net_id);
241+
242+
return tc_action_net_init(tn, &act_sample_ops, SAMPLE_TAB_MASK);
243+
}
244+
245+
static void __net_exit sample_exit_net(struct net *net)
246+
{
247+
struct tc_action_net *tn = net_generic(net, sample_net_id);
248+
249+
tc_action_net_exit(tn);
250+
}
251+
252+
static struct pernet_operations sample_net_ops = {
253+
.init = sample_init_net,
254+
.exit = sample_exit_net,
255+
.id = &sample_net_id,
256+
.size = sizeof(struct tc_action_net),
257+
};
258+
259+
static int __init sample_init_module(void)
260+
{
261+
return tcf_register_action(&act_sample_ops, &sample_net_ops);
262+
}
263+
264+
static void __exit sample_cleanup_module(void)
265+
{
266+
tcf_unregister_action(&act_sample_ops, &sample_net_ops);
267+
}
268+
269+
module_init(sample_init_module);
270+
module_exit(sample_cleanup_module);
271+
272+
MODULE_AUTHOR("Yotam Gigi <[email protected]>");
273+
MODULE_DESCRIPTION("Packet sampling action");
274+
MODULE_LICENSE("GPL v2");

0 commit comments

Comments
 (0)