Skip to content

Commit 77cf078

Browse files
authored
[cli_config] Fix optionalString validValues (#69)
1 parent d40ca93 commit 77cf078

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

pkgs/cli_config/lib/src/config.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ class Config {
225225
for (final source in _sources) {
226226
value ??= source.optionalString(key);
227227
}
228-
if (validValues != null) {
228+
if (value != null && validValues != null) {
229229
Source.throwIfUnexpectedValue(key, value, validValues);
230230
}
231231
return value;

pkgs/cli_config/test/cli_config_test.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,11 @@ void main() {
309309
);
310310
});
311311

312+
test('optionalString validValues', () {
313+
final config = Config();
314+
expect(config.optionalString('foo', validValues: ['bar']), isNull);
315+
});
316+
312317
test('valueOf file source', () {
313318
final config = Config(fileParsed: {
314319
'key': {'some': 'map'}

0 commit comments

Comments
 (0)