Insert reviewed value last [sc-182632]

Author: Fabien Daoulas

dss-plugin-visual-edit/python-lib/DataEditor.py

@@ -461,13 +461,22 @@ def update_row(
         """
         key = get_key_values_from_dict(primary_keys, self.primary_keys)
 
+        def is_reviewed_column(column_name: str):
+            return column_name == "Reviewed" or column_name == "reviewed"
+
+        def is_comments_column(column_name: str):
+            return column_name == "Comments" or column_name == "comments"
+
         # for reviewed column, create an editlog for each columns to enforce values even after a change in the original.
-        if column == "Reviewed" or column == "reviewed":
+        # Append the reviewed value change last in case something goes wrong during updates of the previous column values.
+        # To improve this, the best would be to do all the inserts in the same transaction.
+        if is_reviewed_column(column):
             results = []
             for col in self.editable_column_names:
-                if col != "Comments" and col != "comments":
+                if not is_comments_column(col) and not is_reviewed_column(col):
                     # contains values for primary keys — and other columns too, but they'll be discarded
                     results.append(self.__log_edit__(key, col, primary_keys[col]))
+            results.append(self.__log_edit__(key, column, primary_keys[column]))
             return results
         else:
             return [self.__log_edit__(key, column, value, action="update")]