Skip to content

Commit f2c81c4

Browse files
authored
CNDB-12272: Fix SimpleClientPerfTest (#1477)
### What is the issue SimpleClientPerfTest has been failing in CI since changes from CNDB-10759 ### What does this PR fix and why was it fixed This change in `SimpleClientPerfTest`, updates the anonymous class `Message.Codec<QueryMessage>` to override the correct method, `public CompletableFuture<Response> maybeExecuteAsync` from `QueryMessage`, whose signature was changed as part of CNDB-10759. ### Checklist before you submit for review - [ ] Make sure there is a PR in the CNDB project updating the Converged Cassandra version - [ ] Use `NoSpamLogger` for log lines that may appear frequently in the logs - [ ] Verify test results on Butler - [ ] Test coverage for new/modified code is > 80% - [ ] Proper code formatting - [ ] Proper title for each commit staring with the project-issue number, like CNDB-1234 - [ ] Each commit has a meaningful description - [ ] Each commit is not very long and contains related changes - [ ] Renames, moves and reformatting are in distinct commits
1 parent 6632f3e commit f2c81c4

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

test/burn/org/apache/cassandra/transport/SimpleClientBurnTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,12 @@ public QueryMessage decode(ByteBuf body, ProtocolVersion version)
113113
QueryMessage queryMessage = QueryMessage.codec.decode(body, version);
114114
return new QueryMessage(queryMessage.query, queryMessage.options)
115115
{
116-
public Message.Response executeSync(QueryState state, long queryStartNanoTime, boolean traceRequest)
116+
@Override
117+
public CompletableFuture<Response> maybeExecuteAsync(QueryState state, long queryStartNanoTime, boolean traceRequest)
117118
{
118119
int idx = Integer.parseInt(queryMessage.query);
119120
SizeCaps caps = idx % largeMessageFrequency == 0 ? largeMessageCap : smallMessageCap;
120-
return generateRows(idx, caps);
121+
return CompletableFuture.completedFuture(generateRows(idx, caps));
121122
}
122123
};
123124
}

test/burn/org/apache/cassandra/transport/SimpleClientPerfTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,11 @@ public QueryMessage decode(ByteBuf body, ProtocolVersion version)
172172
QueryMessage queryMessage = QueryMessage.codec.decode(body, version);
173173
return new QueryMessage(queryMessage.query, queryMessage.options)
174174
{
175-
public Message.Response executeSync(QueryState state, long queryStartNanoTime, boolean traceRequest)
175+
@Override
176+
public CompletableFuture<Response> maybeExecuteAsync(QueryState state, long queryStartNanoTime, boolean traceRequest)
176177
{
177178
int idx = Integer.parseInt(queryMessage.query); // unused
178-
return generateRows(idx, responseCaps);
179+
return CompletableFuture.completedFuture(generateRows(idx, responseCaps));
179180
}
180181
};
181182
}

0 commit comments

Comments
 (0)