feat: split the main catalog query into count and main one with sort

Author: juanmahidalgo

src/ports/catalog/component.ts

@@ -7,7 +7,12 @@ import { enhanceItemsWithPicksStats } from '../../logic/favorites/utils'
 import { HttpError } from '../../logic/http/response'
 import { AppComponents } from '../../types'
 import { formatQueryForLogging } from '../utils'
-import { getCollectionsItemsCatalogQuery, getCollectionsItemsCatalogQueryWithTrades, getItemIdsBySearchTextQuery } from './queries'
+import {
+  getCollectionsItemsCatalogQuery,
+  getCollectionsItemsCatalogQueryWithTrades,
+  getCollectionsItemsCountQuery,
+  getItemIdsBySearchTextQuery
+} from './queries'
 import { CatalogOptions, CollectionsItemDBResult, ICatalogComponent } from './types'
 import { fromCollectionsItemDbResultToCatalogItem } from './utils'
 
@@ -62,9 +67,13 @@ export async function createCatalogComponent(
         }
       }
       query = isV2 ? getCollectionsItemsCatalogQueryWithTrades(filters) : getCollectionsItemsCatalogQuery(filters)
-      const results = await client.query<CollectionsItemDBResult>(query)
-      catalogItems = results.rows.map(res => fromCollectionsItemDbResultToCatalogItem(res, network))
-      total = results.rows[0]?.total ?? results.rows[0]?.total_rows ?? 0
+      const totalQuery = getCollectionsItemsCountQuery(filters)
+      const [items, totalItems] = await Promise.all([
+        client.query<CollectionsItemDBResult>(query),
+        client.query<{ total: number }>(totalQuery)
+      ])
+      catalogItems = items.rows.map(res => fromCollectionsItemDbResultToCatalogItem(res, network))
+      total = totalItems.rows[0]?.total ?? 0
 
       const pickStats = await picks.getPicksStats(
         catalogItems.map(({ id }) => id),

src/ports/catalog/queries.ts

@@ -703,6 +703,27 @@ const getTopNItemsCTE = (filters: CatalogQueryFilters) => {
   return SQL``
 }
 
+export const getCollectionsItemsCountQuery = (filters: CatalogQueryFilters) => {
+  return SQL``
+    .append(getTradesCTE())
+    .append(getNFTsWithOrdersCTE(filters))
+    .append(
+      SQL`
+        SELECT COUNT(*) as total
+        FROM `
+    )
+    .append(MARKETPLACE_SQUID_SCHEMA)
+    .append(SQL`.item AS items`)
+    .append(filters.isOnSale === false ? getOwnersJoin() : SQL``)
+    .append(
+      SQL`
+        LEFT JOIN nfts_with_orders ON nfts_with_orders.item_id = items.id`
+    )
+    .append(getMetadataJoins())
+    .append(getTradesJoin())
+    .append(getCollectionsQueryWhere(filters, true))
+}
+
 export const getCollectionsItemsCatalogQueryWithTrades = (filters: CatalogQueryFilters) => {
   const query = SQL``
     .append(getTradesCTE())
@@ -711,7 +732,6 @@ export const getCollectionsItemsCatalogQueryWithTrades = (filters: CatalogQueryF
     .append(
       SQL`
             SELECT
-              COUNT(*) OVER() as total_rows,
               items.id,
               items.blockchain_id,
               items.search_is_collection_approved,