Skip to content

Commit bf33120

Browse files
committed
improve comments
1 parent df1a206 commit bf33120

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

.github/workflows/slow.yml

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# If you change this name also do it in ci_metrics.yml
22
name: Slow Integration Tests
33

4-
# This workflow always runs to satisfy Branch Protection rules.
5-
# The tests will run when:
4+
# The workflow will always run, but the actual tests will only execute when:
65
# - The workflow is triggered manually
76
# - The workflow is scheduled
87
# - The PR has the "run-slow-tests" label
98
# - The push is to a release branch
10-
# - There are changes to relevant files
11-
# If tests are skipped, the "Slow Integration Tests completed" job (required by Branch Protection rules) succeeds.
9+
# - There are changes to relevant files.
10+
# Note: If no conditions are met, the workflow will complete successfully without running tests
11+
# to satisfy Branch Protection rules.
1212

1313
env:
1414
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -41,7 +41,7 @@ jobs:
4141
permissions:
4242
pull-requests: read
4343
outputs:
44-
code_changes: ${{ steps.changes.outputs.code_changes }}
44+
changes: ${{ steps.changes.outputs.changes }}
4545
steps:
4646
- uses: actions/checkout@v4
4747
- name: Check for changed code
@@ -50,7 +50,7 @@ jobs:
5050
with:
5151
# List of Python files that trigger slow integration tests when modified
5252
filters: |
53-
code_changes:
53+
changes:
5454
- "haystack/components/audio/whisper_local.py"
5555
- "haystack/components/converters/tika.py"
5656
- "test/components/converters/test_tika_doc_converter.py"
@@ -66,7 +66,7 @@ jobs:
6666
github.event_name == 'schedule' ||
6767
(github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'run-slow-tests')) ||
6868
(github.event_name == 'push' && github.ref == 'refs/heads/v[0-9].*[0-9].x') ||
69-
(needs.check-if-changed.outputs.code_changes == 'true')
69+
(needs.check-if-changed.outputs.changes == 'true')
7070
7171
strategy:
7272
matrix:

0 commit comments

Comments
 (0)