Skip to content

Commit 93345c3

Browse files
committed
netfs: Prepare to split read_helper.c
Rename netfs_rreq_unlock() to netfs_rreq_unlock_folios() to make it sound less like it's dropping a lock on an netfs_io_request struct. Remove the 'static' marker on netfs_rreq_unlock_folios() and declaring it in internal.h preparatory to splitting the file. Changes ======= ver #2) - Slide this patch to after the one adding netfs_begin_read(). - As a consequence, don't need to unstatic so many functions. Signed-off-by: David Howells <[email protected]> Reviewed-by: Jeff Layton <[email protected]> cc: [email protected] Link: https://lore.kernel.org/r/164623002861.3564931.17340149482236413375.stgit@warthog.procyon.org.uk/ # v1 Link: https://lore.kernel.org/r/164678215208.1200972.9761906209395002182.stgit@warthog.procyon.org.uk/ # v2 Link: https://lore.kernel.org/r/164692912709.2099075.4349905992838317797.stgit@warthog.procyon.org.uk/ # v3
1 parent 4090b31 commit 93345c3

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

fs/netfs/internal.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@
1515

1616
#define pr_fmt(fmt) "netfs: " fmt
1717

18+
/*
19+
* buffered_read.c
20+
*/
21+
void netfs_rreq_unlock_folios(struct netfs_io_request *rreq);
22+
1823
/*
1924
* objects.c
2025
*/

fs/netfs/read_helper.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ static void netfs_rreq_write_to_cache(struct netfs_io_request *rreq)
250250
* Unlock the folios in a read operation. We need to set PG_fscache on any
251251
* folios we're going to write back before we unlock them.
252252
*/
253-
static void netfs_rreq_unlock(struct netfs_io_request *rreq)
253+
void netfs_rreq_unlock_folios(struct netfs_io_request *rreq)
254254
{
255255
struct netfs_io_subrequest *subreq;
256256
struct folio *folio;
@@ -432,7 +432,7 @@ static void netfs_rreq_assess(struct netfs_io_request *rreq, bool was_async)
432432
return;
433433
}
434434

435-
netfs_rreq_unlock(rreq);
435+
netfs_rreq_unlock_folios(rreq);
436436

437437
clear_bit_unlock(NETFS_RREQ_IN_PROGRESS, &rreq->flags);
438438
wake_up_bit(&rreq->flags, NETFS_RREQ_IN_PROGRESS);

0 commit comments

Comments
 (0)