Skip to content

Commit fb28ad9

Browse files
committed
EES-5934 - FE - Refactoring the changelog page to grab the data for the requested Data Set Version
1 parent 1eb9f50 commit fb28ad9

File tree

5 files changed

+238
-61
lines changed

5 files changed

+238
-61
lines changed

src/explore-education-statistics-admin/src/pages/release/data/ReleaseApiDataSetChangelogPage.tsx

+16-6
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ import { useQuery } from '@tanstack/react-query';
2020
import { generatePath, useParams } from 'react-router-dom';
2121
import React, { useEffect } from 'react';
2222
import WarningMessage from '@common/components/WarningMessage';
23+
import { DataSetVersionStatus } from '@admin/services/apiDataSetService';
24+
25+
const dataSetVersionIsDraft = (dataSetVersionStatus: DataSetVersionStatus) =>
26+
dataSetVersionStatus === 'Draft';
2327

2428
export default function ReleaseApiDataSetChangelogPage() {
2529
const { dataSetId, dataSetVersionId, releaseVersionId, publicationId } =
@@ -31,18 +35,20 @@ export default function ReleaseApiDataSetChangelogPage() {
3135
refetch: refetchDataSet,
3236
} = useQuery(apiDataSetQueries.get(dataSetId));
3337

38+
const { data: dataSetVersion, isLoading: isLoadingDataSetVersion } = useQuery(
39+
apiDataSetVersionQueries.getVersion(dataSetVersionId),
40+
);
41+
3442
const { data: changes, isLoading: isLoadingChanges } = useQuery(
3543
apiDataSetVersionQueries.getChanges(dataSetVersionId),
3644
);
3745

38-
const isDraft = dataSet?.draftVersion?.id === dataSetVersionId;
46+
const isDraft = dataSetVersion
47+
? dataSetVersionIsDraft(dataSetVersion.status)
48+
: false;
3949

4050
const [showForm, toggleShowForm] = useToggle(false);
4151

42-
const dataSetVersion = isDraft
43-
? dataSet?.draftVersion
44-
: dataSet?.latestLiveVersion;
45-
4652
useEffect(() => {
4753
if (isDraft && !dataSetVersion?.notes) {
4854
toggleShowForm.on();
@@ -76,7 +82,11 @@ export default function ReleaseApiDataSetChangelogPage() {
7682
Back to API data set details
7783
</Link>
7884

79-
<LoadingSpinner loading={isLoadingDataSet || isLoadingChanges}>
85+
<LoadingSpinner
86+
loading={
87+
isLoadingDataSet || isLoadingDataSetVersion || isLoadingChanges
88+
}
89+
>
8090
{dataSet && dataSetVersion ? (
8191
<>
8292
<div className="govuk-grid-row">

0 commit comments

Comments
 (0)