-
Notifications
You must be signed in to change notification settings - Fork 42
Build for windows #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't use Windows. I unfortunately cannot provide this. |
you could try running it on a VM |
I don't think I can feasibly run a VM on something like GitHub Actions. That wouldn't be a good idea. I also don't think Windows have any decent automatic pipeline infrastructure for it (at least ones that can easily integrate with the current one), and if it does, I've never dealt with it before. |
I mean building it. Maybe every once in a while you could build it and release it for us, no need for scripts or automated stuff |
I just built gtkcord4 on Windows. I used msys2, and the build worked without problems until the link step, where it failed due to too long command line go's linker tries to pass to gcc (this seems like a bug in go). Anyway, I got around that problem by running the link command manually, so if anybody wants to test, here's my Windows build. |
I had a couple dll errors: libwinpthread-1.dll, libdeflate.dll |
Apparently this is a MSYS2-related issue, I'll try installing it and see what happens |
Oops, fixed, download the archive again. |
BTW, I reported the link issue to go. Until that's solved, there's no easy (automated) way to build gtkcord4 on Windows. |
I've restarted it, and it is now using ~250MB |
This is probably a duplicate of several issues:
It's probably trying to load all the images which causes memory spikes. I'm not too confident on gtkcord4 having no memory leaks. |
I believe it was some other issue. On the first start, it was already on >1GB before me even opening a conversation. Then it went up to around 4GB, after which I restarted the program and it showed normal memory behaviour from there onwards. Must've been a bug or something. |
The build issue is fixed in go master. |
Here's today's Windows build: https://eternallybored.org/misc/gtkcord/gtkcord4-win64-20230528.7z |
BTW, I'm not sure if this is a problem due to Windows or something else, but the console log from gtkcord4 is full of
Looking at the img2 directory, it's full of .tmp.numbers files, and it's similar in the videos directory; the thumbnails directory has some zero-sized .tmp.numbers.jpeg files, and sounds directory has a single message.opus file. |
This is probably because gotkit (one of the libraries that gtkcord4 uses) does atomic file writes by calling From GoDoc:
I think a good solution would be to see if gio has a function for this and use that instead of doing it the Unix way. |
https://github.com/google/renameio might be useful here. Also see golang/go#22397. Gio also has Gio.File.replace. |
tysm man for making it for windows but the original program author should add (for linux only ) in about section .. coz many use windows |
"For Linux only" would imply the program only works on Linux, meaning it does not compile to Windows. Unless you prefer me doing that over not having a Windows binary. |
Leaving this here for future reference: https://github.com/msys2/setup-msys2 |
An official Windows builder is now available via the current Build and Publish workflow as of 15d692a. |
Whoops! It's actually fixed now! I implemented this yesterday and went straight to bed, so yeah. |
could you write instructions or a script for building for windows? or it would be even better if an official build was available.
The text was updated successfully, but these errors were encountered: