actually fix things

Author: dignifiedquire

package.json

@@ -51,16 +51,16 @@
     "stream-pair": "^1.0.3"
   },
   "dependencies": {
-    "async": "^2.0.0-rc.4",
     "babel-runtime": "^6.6.1",
     "duplex-passthrough": "github:diasdavid/duplex-passthrough",
     "ip-address": "^5.8.0",
     "lodash.contains": "^2.4.3",
-    "multistream-select": "^0.6.5",
     "multiaddr": "^1.4.0",
+    "multistream-select": "^0.6.5",
     "peer-id": "^0.6.6",
     "peer-info": "^0.6.2",
-    "protocol-buffers-stream": "^1.3.1"
+    "protocol-buffers-stream": "^1.3.1",
+    "run-parallel": "^1.1.6"
   },
   "aegir": {
     "webpack": {

src/index.js

@@ -1,12 +1,12 @@
 'use strict'
 
-const async = require('async')
 const multistream = require('multistream-select')
 const identify = require('./identify')
 const DuplexPassThrough = require('duplex-passthrough')
 const contains = require('lodash.contains')
 const util = require('util')
 const EE = require('events').EventEmitter
+const parallel = require('run-parallel')
 
 exports = module.exports = Swarm
 
@@ -378,17 +378,9 @@ function Swarm (peerInfo) {
       this.muxedConns[key].muxer.end()
     })
 
-    async.each(
-      Object.keys(this.transports),
-      (key, cb) => {
-        // avoid unhandled error messages
-        this.transports[key].once('error', (err) => {
-          console.log('got error', err)
-        })
-        this.transports[key].close(cb)
-      },
-      callback
-    )
+    parallel(Object.keys(this.transports).map((key) => {
+      return (cb) => this.transports[key].close(cb)
+    }), callback)
   }
 }
 

test/01-transport-tcp.node.js

@@ -3,7 +3,7 @@
 
 const expect = require('chai').expect
 
-const async = require('async')
+const parallel = require('run-parallel')
 const multiaddr = require('multiaddr')
 const Peer = require('peer-info')
 const Swarm = require('../src')
@@ -93,7 +93,7 @@ describe('transport - tcp', function () {
   })
 
   it('close', (done) => {
-    async.parallel([
+    parallel([
       (cb) => swarmA.transport.close('tcp', cb),
       (cb) => swarmB.transport.close('tcp', cb)
     ], done)

test/03-transport-websockets.node.js

@@ -3,7 +3,7 @@
 
 const expect = require('chai').expect
 
-const async = require('async')
+const parallel = require('run-parallel')
 const multiaddr = require('multiaddr')
 const Peer = require('peer-info')
 const Swarm = require('../src')
@@ -89,7 +89,7 @@ describe('transport - websockets', function () {
   })
 
   it('close', (done) => {
-    async.parallel([
+    parallel([
       (cb) => swarmA.transport.close('ws', cb),
       (cb) => swarmB.transport.close('ws', cb)
     ], done)

test/04-muxing-multiplex.node.js

@@ -3,7 +3,7 @@
 
 const expect = require('chai').expect
 
-const async = require('async')
+const parallel = require('run-parallel')
 const multiaddr = require('multiaddr')
 const Peer = require('peer-info')
 const Swarm = require('../src')
@@ -41,15 +41,15 @@ describe('stream muxing with multiplex (on TCP)', function () {
     swarmB.transport.add('tcp', new TCP())
     swarmC.transport.add('tcp', new TCP())
 
-    async.parallel([
+    parallel([
       (cb) => swarmA.transport.listen('tcp', {}, null, cb),
       (cb) => swarmB.transport.listen('tcp', {}, null, cb),
       (cb) => swarmC.transport.listen('tcp', {}, null, cb)
     ], done)
   })
 
   after((done) => {
-    async.parallel([
+    parallel([
       (cb) => swarmA.close(cb),
       (cb) => swarmB.close(cb),
       (cb) => swarmC.close(cb)

test/05-muxing-spdy.node.js

@@ -3,15 +3,15 @@
 
 const expect = require('chai').expect
 
-const async = require('async')
+const parallel = require('run-parallel')
 const multiaddr = require('multiaddr')
 const Peer = require('peer-info')
 const Swarm = require('../src')
 const TCP = require('libp2p-tcp')
 const spdy = require('libp2p-spdy')
 
 describe('stream muxing with spdy (on TCP)', function () {
-  this.timeout(20000)
+  this.timeout(60 * 1000)
 
   var swarmA
   var peerA
@@ -41,15 +41,15 @@ describe('stream muxing with spdy (on TCP)', function () {
     swarmB.transport.add('tcp', new TCP())
     swarmC.transport.add('tcp', new TCP())
 
-    async.parallel([
+    parallel([
       (cb) => swarmA.transport.listen('tcp', {}, null, cb),
       (cb) => swarmB.transport.listen('tcp', {}, null, cb),
       (cb) => swarmC.transport.listen('tcp', {}, null, cb)
     ], done)
   })
 
   after((done) => {
-    async.parallel([
+    parallel([
       (cb) => swarmA.close(cb),
       (cb) => swarmB.close(cb),
       (cb) => swarmC.close(cb)

test/08-swarm-without-muxing.node.js

@@ -3,7 +3,7 @@
 
 const expect = require('chai').expect
 
-const async = require('async')
+const parallel = require('run-parallel')
 const multiaddr = require('multiaddr')
 const Peer = require('peer-info')
 const Swarm = require('../src')
@@ -43,7 +43,7 @@ describe('high level API - 1st without stream multiplexing (on TCP)', function (
   })
 
   after((done) => {
-    async.parallel([
+    parallel([
       (cb) => swarmA.close(cb),
       (cb) => swarmB.close(cb)
     ], done)

test/09-swarm-with-muxing.node.js

@@ -3,7 +3,7 @@
 
 const expect = require('chai').expect
 
-const async = require('async')
+const parallel = require('run-parallel')
 const multiaddr = require('multiaddr')
 const Peer = require('peer-info')
 const Swarm = require('../src')
@@ -46,7 +46,7 @@ describe('high level API - with everything mixed all together!', function () {
   })
 
   after((done) => {
-    async.parallel([
+    parallel([
       (cb) => swarmA.close(cb),
       (cb) => swarmB.close(cb),
       // (cb) => swarmC.close(cb),