Skip to content

Fail tests that leak pipes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunshowers opened this issue Mar 19, 2021 · 0 comments
Open

Fail tests that leak pipes #27

sunshowers opened this issue Mar 19, 2021 · 0 comments
Milestone

Comments

@sunshowers
Copy link
Contributor

It is possible to write a test that ends up leaking a pipe (e.g. creates a process but doesn't terminate it). Currently, the test runner hangs on encountering such a test.

Instead, we should figure out a way to:

  • detect such a situation (a small amount of raciness between waiting on process exit and checking that the handles are closed is fine)
  • mark such a test as failure with a LEAK message or similar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant