Skip to content

Commit 6694e27

Browse files
melinathDave Karwowski
authored and
Dave Karwowski
committed
Documented review cases that require additional scrutiny (GoogleCloudPlatform#12615)
1 parent e921adc commit 6694e27

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

docs/content/code-review/review-pr.md

+9
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,15 @@ aliases:
99

1010
This page provides guidelines for reviewing a Magic Modules pull request (PR).
1111

12+
## Special cases
13+
14+
The following types of PRs may require additional scrutiny and/or multiple reviewers.
15+
16+
- DCL to MMv1 migrations
17+
- Adding multi-actor fields (fields whose values can be altered as a side effect of changes made to a different resource)
18+
19+
## Review
20+
1221
1. Read the PR description to understand the context and ensure the PR either
1322
* is linked to a GitHub issue or an internal bug
1423
* if not, check the [issue tracker](https://github.com/hashicorp/terraform-provider-google/issues) to see whether the feature has already been requested and add the issues in the description, if any.

0 commit comments

Comments
 (0)