Use NOLINT instead.

Author: trivialfis

include/xgboost/base.h

@@ -84,13 +84,6 @@
 #define XGBOOST_DEVICE
 #endif  // defined (__CUDA__) || defined(__NVCC__)
 
-#if defined(__CUDACC_VER_MAJOR__) && __CUDACC_VER_MAJOR__ < 10
-// Default constructor on device
-#define XGBOOST_DEV_DFT_CTOR __host__ __device__
-#else
-#define XGBOOST_DEV_DFT_CTOR
-#endif
-
 // These check are for Makefile.
 #if !defined(XGBOOST_MM_PREFETCH_PRESENT) && !defined(XGBOOST_BUILTIN_PREFETCH_PRESENT)
 /* default logic for software pre-fetching */

src/common/bitfield.h

@@ -82,7 +82,7 @@ struct BitFieldContainer {
   }
 
  public:
-  XGBOOST_DEV_DFT_CTOR BitFieldContainer() = default;
+  BitFieldContainer() = default;
   XGBOOST_DEVICE explicit BitFieldContainer(common::Span<value_type> bits) : bits_{bits} {}
   XGBOOST_DEVICE BitFieldContainer(BitFieldContainer const& other) : bits_{other.bits_} {}
 

src/metric/metric_common.h

@@ -66,7 +66,7 @@ class PackedReduceResult {
   double weights_sum_ { 0 };
 
  public:
-  XGBOOST_DEV_DFT_CTOR PackedReduceResult() = default;
+  XGBOOST_DEVICE PackedReduceResult() {}  // NOLINT
   XGBOOST_DEVICE PackedReduceResult(double residue, double weight)
       : residue_sum_{residue}, weights_sum_{weight} {}
 

src/tree/updater_gpu_common.cuh

@@ -61,7 +61,7 @@ struct DeviceSplitCandidate {
   GradientPair left_sum;
   GradientPair right_sum;
 
-  XGBOOST_DEV_DFT_CTOR DeviceSplitCandidate() = default;
+  XGBOOST_DEVICE DeviceSplitCandidate() {}  // NOLINT
 
   template <typename ParamT>
   XGBOOST_DEVICE void Update(const DeviceSplitCandidate& other,
@@ -130,7 +130,7 @@ struct DeviceNodeStats {
   /** node id (used as key for reduce/scan) */
   NodeIdT idx{kUnusedNode};
 
-  XGBOOST_DEV_DFT_CTOR DeviceNodeStats() = default;
+  XGBOOST_DEVICE DeviceNodeStats() {}  // NOLINT
 
   template <typename ParamT>
   HOST_DEV_INLINE DeviceNodeStats(GradientPair sum_gradients, NodeIdT nidx,