Skip to content

Commit 68b838d

Browse files
committed
remove in no sampling.
1 parent f383f76 commit 68b838d

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/tree/gpu_hist/gradient_based_sampler.cu

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,12 @@ class PoissonSampling : public thrust::binary_function<GradientPair, size_t, Gra
146146
CombineGradientPair combine_;
147147
};
148148

149-
NoSampling::NoSampling(EllpackPageImpl const* page) : page_(page) {}
149+
NoSampling::NoSampling(BatchParam batch_param) : batch_param_(std::move(batch_param)) {}
150150

151-
GradientBasedSample NoSampling::Sample(Context const*, common::Span<GradientPair> gpair,
151+
GradientBasedSample NoSampling::Sample(Context const* ctx, common::Span<GradientPair> gpair,
152152
DMatrix* dmat) {
153-
return {dmat->Info().num_row_, page_, gpair};
153+
auto page = (*dmat->GetBatches<EllpackPage>(ctx, batch_param_).begin()).Impl();
154+
return {dmat->Info().num_row_, page, gpair};
154155
}
155156

156157
ExternalMemoryNoSampling::ExternalMemoryNoSampling(Context const* ctx, EllpackPageImpl const* page,
@@ -349,7 +350,7 @@ GradientBasedSampler::GradientBasedSampler(Context const* ctx, EllpackPageImpl c
349350
if (is_external_memory) {
350351
strategy_.reset(new ExternalMemoryNoSampling(ctx, page, n_rows, batch_param));
351352
} else {
352-
strategy_.reset(new NoSampling(page));
353+
strategy_.reset(new NoSampling(batch_param));
353354
}
354355
}
355356
}

src/tree/gpu_hist/gradient_based_sampler.cuh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ class SamplingStrategy {
3232
/*! \brief No sampling in in-memory mode. */
3333
class NoSampling : public SamplingStrategy {
3434
public:
35-
explicit NoSampling(EllpackPageImpl const* page);
35+
explicit NoSampling(BatchParam batch_param);
3636
GradientBasedSample Sample(Context const* ctx, common::Span<GradientPair> gpair,
3737
DMatrix* dmat) override;
3838

3939
private:
40-
EllpackPageImpl const* page_;
40+
BatchParam batch_param_;
4141
};
4242

4343
/*! \brief No sampling in external memory mode. */

0 commit comments

Comments
 (0)