Skip to content

Commit f23a2be

Browse files
committed
Add explicit "cli" aliases and move "latest" to "dind" in 22.06+
1 parent 5bda34e commit f23a2be

17 files changed

+33
-19
lines changed
File renamed without changes.
File renamed without changes.
File renamed without changes.

20.10/dind/Dockerfile

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

20.10/git/Dockerfile

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
File renamed without changes.
File renamed without changes.
File renamed without changes.

22.06-rc/dind/Dockerfile

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

22.06-rc/git/Dockerfile

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
File renamed without changes.

Dockerfile-dind.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM docker:{{ env.version }}
1+
FROM docker:{{ env.version }}-cli
22

33
# https://github.com/docker/docker/blob/master/project/PACKAGERS.md#runtime-dependencies
44
RUN set -eux; \

Dockerfile-git.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
FROM docker:{{ env.version }}
1+
FROM docker:{{ env.version }}-cli
22

33
RUN apk add --no-cache git

apply-templates.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,13 @@ for version; do
3636
continue
3737
fi
3838

39+
rm -rf "$version"
40+
3941
variants="$(jq -r '.[env.version].variants | map(@sh) | join(" ")' versions.json)"
4042
eval "variants=( $variants )"
4143

4244
for variant in "${variants[@]}"; do
43-
dir="$version${variant:+/$variant}"
45+
dir="$version/$variant"
4446

4547
case "$variant" in
4648
windows/*)
@@ -53,7 +55,7 @@ for version; do
5355
;;
5456

5557
*)
56-
template="Dockerfile${variant:+-$variant}.template"
58+
template="Dockerfile-$variant.template"
5759
;;
5860
esac
5961

@@ -64,6 +66,6 @@ for version; do
6466
} > "$dir/Dockerfile"
6567
done
6668

67-
cp -a docker-entrypoint.sh modprobe.sh "$version/"
69+
cp -a docker-entrypoint.sh modprobe.sh "$version/cli/"
6870
cp -a dockerd-entrypoint.sh "$version/dind/"
6971
done

generate-stackbrew-library.sh

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
#!/bin/bash
2-
set -eu
1+
#!/usr/bin/env bash
2+
set -Eeuo pipefail
33

44
self="$(basename "$BASH_SOURCE")"
55
cd "$(dirname "$(readlink -f "$BASH_SOURCE")")"
@@ -72,7 +72,7 @@ versionArches() {
7272
fi
7373

7474
local parent parentArches
75-
parent="$(awk 'toupper($1) == "FROM" { print $2 }' "$version/Dockerfile")"
75+
parent="$(awk 'toupper($1) == "FROM" { print $2 }' "$version/cli/Dockerfile")"
7676
parentArches="${parentRepoToArches[$parent]:-}"
7777

7878
comm -12 \
@@ -157,23 +157,35 @@ for version; do
157157
variants="$(jq -r '.[env.version].variants | map(@sh) | join(" ")' versions.json)"
158158
eval "variants=( $variants )"
159159

160+
case "$rcVersion" in
161+
20.10) latestVariant='cli' ;;
162+
*) latestVariant='dind' ;;
163+
esac
164+
160165
for v in "${variants[@]}"; do
161-
dir="$version${v:+/$v}"
166+
dir="$version/$v"
162167
[ -f "$dir/Dockerfile" ] || continue
163168

164169
commit="$(dirCommit "$dir")"
165170

166171
variant="$(basename "$v")"
167-
variantAliases=( "${versionAliases[@]/%/${variant:+-$variant}}" )
172+
variantAliases=( "${versionAliases[@]/%/-$variant}" )
168173
variantAliases=( "${variantAliases[@]//latest-/}" )
169174

170-
if [ "$variant" = '' ] || [ "$variant" = 'dind' ]; then
171-
parent="$(awk 'toupper($1) == "FROM" { print $2 }' "$version/Dockerfile")"
175+
if [ "$variant" = 'cli' ] || [ "$variant" = 'dind' ]; then
176+
parent="$(awk 'toupper($1) == "FROM" { print $2 }' "$version/cli/Dockerfile")"
172177
alpine="${parent#*:}" # "3.14"
173178
suiteAliases=( "${variantAliases[0]}" ) # only "X.Y.Z-foo"
174179
suiteAliases=( "${suiteAliases[@]/%/-alpine$alpine}" )
175180
suiteAliases=( "${suiteAliases[@]//latest-/}" )
176181
variantAliases+=( "${suiteAliases[@]}" )
182+
if [ "$variant" = "$latestVariant" ]; then
183+
# add "latest" aliases
184+
suiteAliases=( "${versionAliases[0]}" ) # only "X.Y.Z-foo"
185+
suiteAliases=( "${suiteAliases[@]/%/-alpine$alpine}" )
186+
suiteAliases=( "${suiteAliases[@]//latest-/}" )
187+
variantAliases+=( "${versionAliases[@]}" "${suiteAliases[@]}" )
188+
fi
177189
fi
178190

179191
sharedTags=()

versions.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
},
122122
"dindCommit": "42b1175eda071c0e9121e1d64345928384a93df1",
123123
"variants": [
124-
"",
124+
"cli",
125125
"dind",
126126
"dind-rootless",
127127
"git",
@@ -254,7 +254,7 @@
254254
},
255255
"dindCommit": "42b1175eda071c0e9121e1d64345928384a93df1",
256256
"variants": [
257-
"",
257+
"cli",
258258
"dind",
259259
"dind-rootless",
260260
"git",

versions.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ for version in "${versions[@]}"; do
250250

251251
# order here controls the order of the library/ file
252252
for variant in \
253-
'' \
253+
cli \
254254
dind \
255255
dind-rootless \
256256
git \

0 commit comments

Comments
 (0)