Skip to content

Commit 37df5a2

Browse files
committed
pkg/compose: remove uses of ExecOptions.Detach
This field was added in [moby@5130fe5d38837302e], which added it for use as intermediate struct when parsing CLI flags (through `runconfig.ParseExec`) in [moby@c786a8ee5e9db8f5f]. Commit [moby@9d9dff3d0d9e92adf] rewrote the CLI to use Cobra, and as part of this introduced a separate `execOptions` type in `api/client/container`, however the ExecOptions.Detach field was still used as intermediate field to store the flag's value. Given that the client doesn't use this field, let's remove its use to prevent giving the impression that it's used anywhere. [moby@5130fe5d38837302e]: moby/moby@5130fe5 [moby@c786a8ee5e9db8f5f]: moby/moby@c786a8e [moby@9d9dff3d0d9e92adf]: moby/moby@9d9dff3 Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 22e23bd commit 37df5a2

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

pkg/compose/hook.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ func (s composeService) runHook(ctx context.Context, ctr container.Summary, serv
4848
Env: ToMobyEnv(hook.Environment),
4949
WorkingDir: hook.WorkingDir,
5050
Cmd: hook.Command,
51-
Detach: detached,
5251
AttachStdout: !detached,
5352
AttachStderr: !detached,
5453
})

0 commit comments

Comments
 (0)