Simplify logical condition to use AND with short-circuiting

Copilot · mandel-macaque · Copilot · commit 0b203a42f748 · 2025-06-13T18:46:07.000Z
Co-authored-by: mandel-macaque &lt;2190086+mandel-macaque@users.noreply.github.com&gt;
diff --git a/msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworks.cs b/msbuild/Xamarin.MacDev.Tasks/Tasks/FilterStaticFrameworks.cs
@@ -22,7 +22,7 @@ public class FilterStaticFrameworks : XamarinTask, ITaskCallback {
 
 		static string GetFrameworkExecutablePath (string frameworkPath)
 		{
-			if (!frameworkPath.EndsWith (".framework", StringComparison.OrdinalIgnoreCase) || !Directory.Exists (frameworkPath))
+			if (!(frameworkPath.EndsWith (".framework", StringComparison.OrdinalIgnoreCase) && Directory.Exists (frameworkPath)))
 				return frameworkPath;
 
 			// Try to read the CFBundleExecutable from Info.plist

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public class FilterStaticFrameworks : XamarinTask, ITaskCallback {`
`22`	`22`
`23`	`23`	`static string GetFrameworkExecutablePath (string frameworkPath)`
`24`	`24`	`{`
`25`		`- if (!frameworkPath.EndsWith (".framework", StringComparison.OrdinalIgnoreCase) \|\| !Directory.Exists (frameworkPath))`
	`25`	`+ if (!(frameworkPath.EndsWith (".framework", StringComparison.OrdinalIgnoreCase) && Directory.Exists (frameworkPath)))`
`26`	`26`	`return frameworkPath;`
`27`	`27`
`28`	`28`	`// Try to read the CFBundleExecutable from Info.plist`