Skip to content

Commit b0216e5

Browse files
CopilotCarnaViire
andcommitted
Fix HttpClientFactoryDisposeTests to create distinct client handlers
Co-authored-by: CarnaViire <[email protected]>
1 parent efa49e1 commit b0216e5

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/libraries/Microsoft.Extensions.Http/tests/Microsoft.Extensions.Http.Tests/HttpClientFactoryDisposeTests.cs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,13 @@ public async Task DisposingServiceProvider_DisposesHttpClientFactory_ReleasesRes
2424
var services = new ServiceCollection();
2525
services.AddSingleton(disposeCounter);
2626

27-
// Add HttpClient services
28-
services.AddHttpClient("test-client", client => { })
29-
.ConfigurePrimaryHttpMessageHandler(() => new DisposeTrackingHandler(disposeCounter));
27+
// Register handlers for multiple named clients
28+
for (int i = 0; i < ClientCount; i++)
29+
{
30+
string clientName = $"test-client-{i}";
31+
services.AddHttpClient(clientName, client => { })
32+
.ConfigurePrimaryHttpMessageHandler(() => new DisposeTrackingHandler(disposeCounter));
33+
}
3034

3135
// Build service provider
3236
var serviceProvider = services.BuildServiceProvider();
@@ -35,7 +39,8 @@ public async Task DisposingServiceProvider_DisposesHttpClientFactory_ReleasesRes
3539
// Create clients to initialize handlers
3640
for (int i = 0; i < ClientCount; i++)
3741
{
38-
var client = factory.CreateClient("test-client");
42+
string clientName = $"test-client-{i}";
43+
var client = factory.CreateClient(clientName);
3944

4045
// Use the client to ensure the handler is created
4146
var response = await client.SendAsync(new HttpRequestMessage(HttpMethod.Get, "http://example.com"));

0 commit comments

Comments
 (0)