dont try to release mapping if VirtualAlloc fails (#116794)

mangod9 · web-flow · commit f4bc4688becd · 2025-06-18T14:09:10.000-07:00
diff --git a/src/coreclr/minipal/Windows/doublemapping.cpp b/src/coreclr/minipal/Windows/doublemapping.cpp
@@ -193,6 +193,10 @@ bool VMToOSInterface::ReleaseDoubleMappedMemory(void *mapperHandle, void* pStart
 {
     LPVOID  result = VirtualAlloc(pStart, size, MEM_COMMIT, PAGE_READWRITE);
     assert(result != NULL);
+    if (result == NULL)
+    {
+        return false;
+    }
     memset(pStart, 0, size);
     return UnmapViewOfFile(pStart);
 }

Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,10 @@ bool VMToOSInterface::ReleaseDoubleMappedMemory(void mapperHandle, void pStart`
`193`	`193`	`{`
`194`	`194`	`LPVOID result = VirtualAlloc(pStart, size, MEM_COMMIT, PAGE_READWRITE);`
`195`	`195`	`assert(result != NULL);`
	`196`	`+ if (result == NULL)`
	`197`	`+ {`
	`198`	`+ return false;`
	`199`	`+ }`
`196`	`200`	`memset(pStart, 0, size);`
`197`	`201`	`return UnmapViewOfFile(pStart);`
`198`	`202`	`}`