Skip to content

Addressing mode was not contained #112692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xtqqczze opened this issue Feb 19, 2025 · 3 comments
Closed

Addressing mode was not contained #112692

xtqqczze opened this issue Feb 19, 2025 · 3 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@xtqqczze
Copy link
Contributor

xtqqczze commented Feb 19, 2025 •
edited
Loading

We should really just use MemoryMarshal.Write, but the codegen is suboptimal, see sharplab

Looks like a simple addressing mode was not contained. It's just that this PR replaces one unsafe code with another unsafe (a tiny bit better, but still). These APIs allocate, it is unlikely an extra lea makes perf difference here

@jakobbotsch do we have an issue tracking this?

Originally posted by @xtqqczze in #112616 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 19, 2025
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Feb 19, 2025
@jkotas jkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 19, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Feb 19, 2025
@JulieLeeMSFT JulieLeeMSFT added this to the Future milestone Feb 19, 2025
@JulieLeeMSFT
Copy link
Member

cc @dotnet/jit-contrib.

@jakobbotsch
Copy link
Member

It turns out we did have an issue for this in #104538. Going to close as a duplicate.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@jkotas @jakobbotsch @xtqqczze @JulieLeeMSFT