dotnet tool install --local works by default, by creating a manifest by default, utilizing --create-manifest-if-needed (#48906)

Author: marcpopMSFT

src/Cli/dotnet/CliStrings.resx

@@ -577,8 +577,8 @@ The default is 'false.' However, when targeting .NET 7 or lower, the default is
     <value>outputpathresolver: {0} does not exist</value>
   </data>
   <data name="CannotFindAManifestFile" xml:space="preserve">
-    <value>Cannot find a manifest file.
-For a list of locations searched, specify the "-d" option before the tool name.</value>
+    <value>Cannot find a manifest file. The list of searched paths:
+{0}</value>
   </data>
   <data name="CannotFindPackageIdInManifest" xml:space="preserve">
     <value>Cannot find a package with the package id {0} in the manifest file.</value>
@@ -670,10 +670,6 @@ For a list of locations searched, specify the "-d" option before the tool name.<
   <data name="LibraryNotFoundInLockFile" xml:space="preserve">
     <value>{0}: library not found in lock file.</value>
   </data>
-  <data name="ListOfSearched" xml:space="preserve">
-    <value>The list of searched paths:
-{0}</value>
-  </data>
   <data name="LookingForPreferCliRuntimeFile" xml:space="preserve">
     <value>{0}: Looking for prefercliruntime file at `{1}`</value>
   </data>

src/Cli/dotnet/Commands/CliCommandStrings.resx

@@ -1975,10 +1975,6 @@ Tool '{1}' (version '{2}') was successfully installed.</value>
   <data name="ToolInstallManifestPathOptionName" xml:space="preserve">
     <value>PATH</value>
   </data>
-  <data name="ToolInstallNoManifestGuide" xml:space="preserve">
-    <value>If you intended to install a global tool, add `--global` to the command.
-If you would like to create a manifest, use the `--create-manifest-if-needed` flag with the `dotnet tool install` command, or use `dotnet new tool-manifest`, usually in the repo root directory.</value>
-  </data>
   <data name="ToolInstallNuGetConfigurationFileDoesNotExist" xml:space="preserve">
     <value>NuGet configuration file '{0}' does not exist.</value>
   </data>

src/Cli/dotnet/Commands/Tool/Install/ToolInstallCommandParser.cs

@@ -49,7 +49,8 @@ internal static class ToolInstallCommandParser
     public static readonly Option<bool> CreateManifestIfNeededOption = new("--create-manifest-if-needed")
     {
         Description = CliCommandStrings.CreateManifestIfNeededOptionDescription,
-        Arity = ArgumentArity.Zero
+        Arity = ArgumentArity.ZeroOrOne,
+        DefaultValueFactory = _ => true,
     };
 
     public static readonly Option<bool> AllowPackageDowngradeOption = new("--allow-downgrade")

src/Cli/dotnet/Commands/Tool/Install/ToolInstallLocalCommand.cs

@@ -194,18 +194,8 @@ public int InstallNewTool(FilePath manifestFile, PackageId packageId)
 
     public FilePath GetManifestFilePath()
     {
-        try
-        {
-            return string.IsNullOrWhiteSpace(_explicitManifestFile)
-                ? _toolManifestFinder.FindFirst(_createManifestIfNeeded)
-                : new FilePath(_explicitManifestFile);
-        }
-        catch (ToolManifestCannotBeFoundException e)
-        {
-            throw new GracefulException(
-                [e.Message, CliCommandStrings.ToolInstallNoManifestGuide],
-                verboseMessages: [e.VerboseMessage],
-                isUserError: false);
-        }
+        return string.IsNullOrWhiteSpace(_explicitManifestFile)
+            ? _toolManifestFinder.FindFirst(_createManifestIfNeeded)
+            : new FilePath(_explicitManifestFile);
     }
 }

src/Cli/dotnet/Commands/xlf/CliCommandStrings.cs.xlf

@@ -12,9 +12,4 @@ internal class ToolManifestCannotBeFoundException : GracefulException
     public ToolManifestCannotBeFoundException(string message) : base([message], null, false)
     {
     }
-
-    public ToolManifestCannotBeFoundException(string message, string optionalMessage)
-        : base([message], [optionalMessage], false)
-    {
-    }
 }

src/Cli/dotnet/Commands/xlf/CliCommandStrings.de.xlf

@@ -41,10 +41,7 @@ public IReadOnlyCollection<ToolManifestPackage> Find(FilePath? filePath = null)
 
         if (!findAnyManifest)
         {
-            throw new ToolManifestCannotBeFoundException(
-                CliStrings.CannotFindAManifestFile,
-                string.Format(CliStrings.ListOfSearched,
-                    string.Join(Environment.NewLine, allPossibleManifests.Select(f => "\t" + f.manifestfile.Value))));
+            throw new ToolManifestCannotBeFoundException(string.Format(CliStrings.CannotFindAManifestFile, string.Join(Environment.NewLine, allPossibleManifests.Select(f => "\t" + f.manifestfile.Value))));
         }
 
         return [.. toolManifestPackageAndSource.Select(t => t.toolManifestPackage)];
@@ -182,11 +179,7 @@ public FilePath FindFirst(bool createIfNotFound = false)
                 return new FilePath(WriteManifestFile(manifestInsertFolder));
             }
         }
-        throw new ToolManifestCannotBeFoundException(
-                CliStrings.CannotFindAManifestFile,
-                string.Format(CliStrings.ListOfSearched,
-                    string.Join(Environment.NewLine,
-                        EnumerateDefaultAllPossibleManifests().Select(f => "\t" + f.manifestfile.Value))));
+        throw new ToolManifestCannotBeFoundException(string.Format(CliStrings.CannotFindAManifestFile, string.Join(Environment.NewLine, EnumerateDefaultAllPossibleManifests().Select(f => "\t" + f.manifestfile.Value))));
     }
 
     /*
@@ -274,11 +267,7 @@ in EnumerateDefaultAllPossibleManifests())
 
         if (!findAnyManifest)
         {
-            throw new ToolManifestCannotBeFoundException(
-                CliStrings.CannotFindAManifestFile,
-                string.Format(CliStrings.ListOfSearched,
-                    string.Join(Environment.NewLine,
-                        EnumerateDefaultAllPossibleManifests().Select(f => "\t" + f.manifestfile.Value))));
+            throw new ToolManifestCannotBeFoundException(string.Format(CliStrings.CannotFindAManifestFile, string.Join(Environment.NewLine, EnumerateDefaultAllPossibleManifests().Select(f => "\t" + f.manifestfile.Value))));
         }
 
         return result;