Recognize binlog args

Author: jjonescz

src/Cli/dotnet/Commands/Publish/PublishCommand.cs

@@ -35,7 +35,9 @@ public static CommandBase FromParseResult(ParseResult parseResult, string? msbui
             "--property:_IsPublishing=true" // This property will not hold true for MSBuild /t:Publish or in VS.
         };
 
-        string[] fileArgs = parseResult.GetValue(PublishCommandParser.SlnOrProjectOrFileArgument) ?? [];
+        string[] args = parseResult.GetValue(PublishCommandParser.SlnOrProjectOrFileArgument) ?? [];
+
+        LoggerUtility.SeparateBinLogArguments(args, out var binLogArgs, out var nonBinLogArgs);
 
         CommonOptions.ValidateSelfContainedOptions(parseResult.HasOption(PublishCommandParser.SelfContainedOption),
             parseResult.HasOption(PublishCommandParser.NoSelfContainedOption));
@@ -46,13 +48,15 @@ public static CommandBase FromParseResult(ParseResult parseResult, string? msbui
 
         bool noRestore = noBuild || parseResult.HasOption(PublishCommandParser.NoRestoreOption);
 
-        if (fileArgs is [{ } arg] && VirtualProjectBuildingCommand.IsValidEntryPointPath(arg))
+        if (nonBinLogArgs is [{ } arg] && VirtualProjectBuildingCommand.IsValidEntryPointPath(arg))
         {
             if (!parseResult.HasOption(PublishCommandParser.ConfigurationOption))
             {
                 msbuildArgs.Add("-p:Configuration=Release");
             }
 
+            msbuildArgs.AddRange(binLogArgs);
+
             return new VirtualProjectBuildingCommand(
                 entryPointFileFullPath: Path.GetFullPath(arg),
                 msbuildArgs: msbuildArgs,
@@ -68,14 +72,14 @@ public static CommandBase FromParseResult(ParseResult parseResult, string? msbui
 
         ReleasePropertyProjectLocator projectLocator = new(parseResult, MSBuildPropertyNames.PUBLISH_RELEASE,
             new ReleasePropertyProjectLocator.DependentCommandOptions(
-                    fileArgs,
+                    nonBinLogArgs,
                     parseResult.HasOption(PublishCommandParser.ConfigurationOption) ? parseResult.GetValue(PublishCommandParser.ConfigurationOption) : null,
                     parseResult.HasOption(PublishCommandParser.FrameworkOption) ? parseResult.GetValue(PublishCommandParser.FrameworkOption) : null
                 )
          );
         msbuildArgs.AddRange(projectLocator.GetCustomDefaultConfigurationValueIfSpecified());
 
-        msbuildArgs.AddRange(fileArgs ?? []);
+        msbuildArgs.AddRange(args ?? []);
 
         msbuildArgs.Insert(0, "-target:Publish");
 

test/dotnet.Tests/CommandTests/Run/RunFileTests.cs

@@ -861,14 +861,16 @@ public void Publish_Options()
         var artifactsDir = VirtualProjectBuildingCommand.GetArtifactsPath(programFile);
         if (Directory.Exists(artifactsDir)) Directory.Delete(artifactsDir, recursive: true);
 
-        new DotnetCommand(Log, "publish", "Program.cs", "-c", "Debug", "-p:PublishAot=false")
+        new DotnetCommand(Log, "publish", "Program.cs", "-c", "Debug", "-p:PublishAot=false", "-bl")
             .WithWorkingDirectory(testInstance.Path)
             .Execute()
             .Should().Pass();
 
         new DirectoryInfo(artifactsDir).Sub("publish/debug")
             .Should().Exist()
             .And.HaveFile("Program.deps.json");
+
+        new DirectoryInfo(testInstance.Path).File("msbuild.binlog").Should().Exist();
     }
 
     [PlatformSpecificFact(TestPlatforms.AnyUnix), UnsupportedOSPlatform("windows")]