Skip to content

Commit 20b405f

Browse files
authored
Fix semantic version sorting (#397)
* fix semantic version sorting * lint fix
1 parent a7d4dab commit 20b405f

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

internal/chef/cookbooks.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,17 @@ func (s Service) GetCookbooks(ctx context.Context) (*CookbookListResult, error)
5454
var versions []string
5555

5656
for q := range v.Versions {
57-
versions = append(versions, q)
57+
// semver.Sort requires versions to be prefixed with "v"
58+
versions = append(versions, "v"+q)
5859
}
5960

6061
semver.Sort(versions)
62+
63+
// strip the leading "v" now that we're properly sorted
64+
for i := range versions {
65+
versions[i] = versions[i][1:]
66+
}
67+
6168
ReverseSlice(versions)
6269

6370
cookbook := CookbookListItem{

0 commit comments

Comments
 (0)