Skip to content

GHE Server support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davegaeddert opened this issue Jan 20, 2021 · 0 comments
Open

GHE Server support #2

davegaeddert opened this issue Jan 20, 2021 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@davegaeddert
Copy link
Member

davegaeddert commented Jan 20, 2021 •
edited
Loading

Everything so far should work for self-hosted GHE/PullApprove, except for the domain restriction:

pullapprove-browser-extension/manifest.json

Line 17 in 3b9a1d2

"https://github.com/*"

Matching all domains/pages is the easiest option, but seems pretty aggressive. Listing specific customer domains is not a good option either. I don't think a pattern match like https://*.github.* is possible.

There is also the question of whether self-hosted enterprise customers actually want an extension that is updated automatically, which is not how the self-hosted product works in the first place.
@davegaeddert davegaeddert added enhancement New feature or request question Further information is requested labels Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davegaeddert